Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Check does not fail when number of invalidations increases #16

Closed
LilithHafner opened this issue Oct 18, 2023 · 2 comments · Fixed by #20 or #35
Closed

[bug] Check does not fail when number of invalidations increases #16

LilithHafner opened this issue Oct 18, 2023 · 2 comments · Fixed by #20 or #35

Comments

@LilithHafner
Copy link

JuliaCollections/SortingAlgorithms.jl#61

Screenshot 2023-10-18 at 8 43 05 AM
@KristofferC
Copy link
Contributor

And here the checks fail when the number of invalidations got reduced:

JuliaStrings/InlineStrings.jl#77

image

I'm quite sure the issue is that in the

      if: steps.invs_pr.outputs.total > steps.invs_default.outputs.total
      run: exit 1

line of the script the comparison is a string comparison and not a numerical comparison.

I am not sure this check has ever worked...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants