support custom lease name request #198
Conversation
This could be useful for processes where the lease name across different components Signed-off-by: Benny Zlotnik <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| jlease, err := jumpstarterdevv1alpha1.LeaseFromProtobuf(req.Lease, types.NamespacedName{ | ||
| Namespace: namespace, | ||
| Name: name.String(), | ||
| Name: name, |
There was a problem hiding this comment.
I think this would make sense, we just need to make sure that the server provides a reasonable error if the lease name already exists for example.
There was a problem hiding this comment.
As well as the jmp client. I.e. explaining that if you provide a lease name, it must be unique.
There was a problem hiding this comment.
indeed, i think the generic k8s already exist error is clear, but i'll look
There was a problem hiding this comment.
ack, will mark as approved, if you verify that go ahead and just merge.
This could be useful for processes where the lease name across different components
needs supports in jumpstarter