Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cleaning strings functions from xeus-sql to xvega-bindings #26

Open
marimeireles opened this issue Jan 31, 2021 · 0 comments
Open

Remove cleaning strings functions from xeus-sql to xvega-bindings #26

marimeireles opened this issue Jan 31, 2021 · 0 comments

Comments

@marimeireles
Copy link
Member

@wangfenjin introduced a new way to clean strings and it seems better to me.

However we shouldn't have this kind of common tool inside the kernel, it should be moved to the utils.hpp file on the xvega-bindings project.

It'd probably be nice to incorporate the same changes that took place here regarding cleaning strings on xeus-sql.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marimeireles