-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch & upgrade to quickjs-ng 7.0.0 #216
Comments
I don’t know how CMake works, so I’m reluctant to add a dependency on CMake to this project. If you want to maintain the quickjs-ng variants I’m happy to accept a PR updating the build process to work with quickjs-ng 7 |
Afraid I probably know less than you about how CMake works... :-/ |
@justjake Hey there! Can you point me to where you build quickjs? I can help. |
@saghul id appreciate the support. I template Variant.mk into each variant, then run |
Here’s the make rule for quickjs: quickjs-emscripten/templates/Variant.mk Line 151 in aa48b61
|
I think one issue I encountered trying to adapt newer quickjs-ng is that it’s harder to enable malloc_usable_size and other memory accounting features in quickjs-ng for Emscripten environment. Emscripten appears to provide a malloc_usable_size but perhaps the original authors thought it’s a useless feature in web? Or maybe it has bugs? But between cmake being intimidating and some of the ifdef changes I gave up on quickjs-ng |
I'll look into this. |
quickjs-ng 7.0.0 has been released, so would be nice to update this project to that version
Additionally, it seems that quickjs-ng has much more traction than quickjs, so maybe make quickjs-ng the default?
The text was updated successfully, but these errors were encountered: