Skip to content

Unnecessary modifications are made #117

@jzbrooks

Description

@jzbrooks

Describe the bug
This path modifies an absolute command to become relative and toggles back and forth between the two on subsequent runs. This creates git history noise. The command should ideally only be modified if it is a net positive benefit, and modification should be avoided if two options are the same length

 <vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:viewportHeight="24" android:viewportWidth="41" android:width="41dp">
-  <path android:fillColor="#ff3008" android:pathData="M39.043,6.335a10.182,10.182,0,0,0,-9.008-5.429H1.558C1.01,0.906 0.59,1.361 0.59,1.913c0,0.26 0.097,0.52 0.29,0.683L7.079,8.87a2.926,2.926,0,0,0,2.067,0.878h20.082c1.421,0 2.615,1.138 2.615,2.568 0,1.431-1.13,2.634-2.55,2.634H15.442c-0.549,0-0.969,0.455-0.969,1.007 0,0.26 0.097,0.521 0.291,0.683l6.166,6.274a2.926,2.926,0,0,0,2.067,0.878h6.263c8.169,0 14.336-8.777 9.783-17.457Z"/>
+  <path android:fillColor="#ff3008" android:pathData="M39.043,6.335a10.182,10.182,0,0,0,-9.008-5.429H1.558c-0.548-0-0.968,0.455-0.968,1.007 0,0.26 0.097,0.52 0.29,0.683L7.079,8.87a2.926,2.926,0,0,0,2.067,0.878h20.082c1.421,0 2.615,1.138 2.615,2.568 0,1.431-1.13,2.634-2.55,2.634H15.442c-0.549,0-0.969,0.455-0.969,1.007 0,0.26 0.097,0.521 0.291,0.683l6.166,6.274a2.926,2.926,0,0,0,2.067,0.878h6.263c8.169,0 14.336-8.777 9.783-17.457Z"/>

The command

-C1.01,0.906 0.59,1.361 0.59,1.913c0,0.26 0.097,0.52 0.29,0.683
+c-0.548-0-0.968,0.455-0.968,1.007 0,0.26 0.097,0.52 0.29,0.683

vgo version
3.0

Visual Comparison
There's no visual difference

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions