Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"can be marked override" warnings for gzstreambuf functions: C++11 support? #3

Open
int-ua opened this issue Sep 14, 2020 · 0 comments

Comments

@int-ua
Copy link

int-ua commented Sep 14, 2020

I'm trying to use this library as a git submodule and getting these errors:

##[error]libraries/gzstream/gzstream.h:69:21: error: ‘virtual int gzstreambuf::overflow(int)’ can be marked override [-Werror=suggest-override]
Makefile:915: recipe for target 'obj/cata_utility.o' failed
     virtual int     overflow( int c = EOF);
                     ^~~~~~~~
##[error]libraries/gzstream/gzstream.h:70:21: error: ‘virtual int gzstreambuf::underflow()’ can be marked override [-Werror=suggest-override]
     virtual int     underflow();
                     ^~~~~~~~~
##[error]libraries/gzstream/gzstream.h:71:21: error: ‘virtual int gzstreambuf::sync()’ can be marked override [-Werror=suggest-override]
     virtual int     sync();
                     ^~~~

https://github.com/CleverRaven/Cataclysm-DDA/runs/1111118107
Not sure if it's a gzstream problem but posting here just in case it is.

@int-ua int-ua changed the title "can be marked override" warnings for gzstreambuf functions "can be marked override" warnings for gzstreambuf functions: C++11 support? Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant