Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordPlugin.renderMicStream overinitializes AudioContext #4007

Closed
jaredjj3 opened this issue Jan 23, 2025 · 0 comments
Closed

RecordPlugin.renderMicStream overinitializes AudioContext #4007

jaredjj3 opened this issue Jan 23, 2025 · 0 comments

Comments

@jaredjj3
Copy link

This is just a nit, I'm not sure if it actually matters. Feel free to close.

From MDN docs:

It's recommended to create one AudioContext and reuse it instead of initializing a new one each time, and it's OK to use a single AudioContext for several different audio sources and pipeline concurrently

However, RecordPlugin.renderMicStream re-initializes it every time it's called.

const audioContext = new AudioContext()

Repository owner locked and limited conversation to collaborators Jan 23, 2025
@katspaugh katspaugh converted this issue into discussion #4008 Jan 23, 2025

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant