From e668e1c1185db4078c08a100aa9ea1c8fbcb2c41 Mon Sep 17 00:00:00 2001
From: shellyear <boolevafunkce@gmail.com>
Date: Sat, 6 Apr 2024 00:15:22 +0200
Subject: [PATCH 1/5] [chore] add eslint rule for js, jsx file to prevent use
 of 'use strict' in files

---
 .eslintrc.cjs                                         | 11 +++++++++--
 src/components/HelpIcon.jsx                           |  2 --
 src/components/HorizontalInput.jsx                    |  2 --
 src/components/Input.jsx                              |  2 --
 src/components/dashboard/DashboardController.jsx      |  2 --
 src/components/dashboard/DashboardTile.jsx            |  2 --
 src/components/institution/InstitutionTable.jsx       |  2 --
 src/components/institution/InstitutionsController.jsx |  2 --
 src/components/login/Login.jsx                        |  2 --
 src/components/login/PasswordReset.jsx                |  2 --
 src/components/login/PasswordToken.jsx                |  2 --
 src/components/record/RecordController.jsx            |  2 --
 src/components/record/RecordForm.jsx                  |  2 --
 src/components/record/RecordProvenance.jsx            |  2 --
 src/components/record/RequiredAttributes.jsx          |  2 --
 src/components/user/UserController.jsx                |  2 --
 src/components/user/UsersController.jsx               |  2 --
 src/constants/Vocabulary.js                           |  2 --
 src/index.jsx                                         |  2 --
 src/stores/I18nStore.js                               |  2 --
 src/utils/DataFilter.js                               |  2 --
 src/utils/EntityFactory.js                            |  2 --
 src/utils/Logger.js                                   |  2 --
 src/utils/Routes.jsx                                  |  2 --
 src/utils/Routing.js                                  |  2 --
 src/utils/RoutingRules.js                             |  2 --
 src/utils/Utils.js                                    |  1 -
 src/utils/injectIntl.js                               |  2 --
 src/validation/InstitutionValidator.jsx               |  2 --
 src/validation/RecordValidator.jsx                    |  1 -
 src/validation/UserValidator.jsx                      |  2 --
 31 files changed, 9 insertions(+), 60 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index bf0d81e4..cdc94a6c 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -8,8 +8,15 @@ module.exports = {
     },
   },
   plugins: ["react", "react-hooks"],
-  rules: {}, // add specific rules here
-  ignorePatterns: ["dist", "tests", ".eslintrc.cjs"],
+  overrides: [
+    {
+      files: ["*.js", "*.jsx"], // Target all JSX files
+      rules: {
+        strict: ["error", "global"], // Apply "use strict" globally within src folder
+      },
+    },
+  ],
+  ignorePatterns: ["dist", "tests", "public", ".eslintrc.cjs"],
   settings: {
     react: {
       version: "detect",
diff --git a/src/components/HelpIcon.jsx b/src/components/HelpIcon.jsx
index dcc1b08b..f2f2d893 100644
--- a/src/components/HelpIcon.jsx
+++ b/src/components/HelpIcon.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { OverlayTrigger, Tooltip } from "react-bootstrap";
 import PropTypes from "prop-types";
diff --git a/src/components/HorizontalInput.jsx b/src/components/HorizontalInput.jsx
index 0851e7a5..8a1eb455 100644
--- a/src/components/HorizontalInput.jsx
+++ b/src/components/HorizontalInput.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React, { forwardRef } from "react";
 import { Col, FormCheck, FormControl, FormGroup, FormLabel, FormText, InputGroup } from "react-bootstrap";
 import PropTypes from "prop-types";
diff --git a/src/components/Input.jsx b/src/components/Input.jsx
index e35dc642..44d536ca 100644
--- a/src/components/Input.jsx
+++ b/src/components/Input.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React, { forwardRef } from "react";
 import { FormLabel, FormGroup, FormControl, FormText, FormCheck } from "react-bootstrap";
 import PropTypes from "prop-types";
diff --git a/src/components/dashboard/DashboardController.jsx b/src/components/dashboard/DashboardController.jsx
index 77b7962a..a4538a0e 100644
--- a/src/components/dashboard/DashboardController.jsx
+++ b/src/components/dashboard/DashboardController.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import Dashboard from "./Dashboard";
 import React from "react";
 import { connect } from "react-redux";
diff --git a/src/components/dashboard/DashboardTile.jsx b/src/components/dashboard/DashboardTile.jsx
index e1b5548d..be5e75ca 100644
--- a/src/components/dashboard/DashboardTile.jsx
+++ b/src/components/dashboard/DashboardTile.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import PropTypes from "prop-types";
 
diff --git a/src/components/institution/InstitutionTable.jsx b/src/components/institution/InstitutionTable.jsx
index 1f4d8ba6..fb655c6a 100644
--- a/src/components/institution/InstitutionTable.jsx
+++ b/src/components/institution/InstitutionTable.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { Table } from "react-bootstrap";
 
diff --git a/src/components/institution/InstitutionsController.jsx b/src/components/institution/InstitutionsController.jsx
index f7fed910..1ab5a433 100644
--- a/src/components/institution/InstitutionsController.jsx
+++ b/src/components/institution/InstitutionsController.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import Routes from "../../constants/RoutesConstants";
 import { transitionToWithOpts } from "../../utils/Routing";
diff --git a/src/components/login/Login.jsx b/src/components/login/Login.jsx
index 5d6e19d6..0506d974 100644
--- a/src/components/login/Login.jsx
+++ b/src/components/login/Login.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React, { useEffect, useRef, useState } from "react";
 import { Alert, Button, Form, Card } from "react-bootstrap";
 import HorizontalInput from "../HorizontalInput";
diff --git a/src/components/login/PasswordReset.jsx b/src/components/login/PasswordReset.jsx
index c635ee3a..13a79caa 100644
--- a/src/components/login/PasswordReset.jsx
+++ b/src/components/login/PasswordReset.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { Button, Form, Card } from "react-bootstrap";
 import HorizontalInput from "../HorizontalInput";
diff --git a/src/components/login/PasswordToken.jsx b/src/components/login/PasswordToken.jsx
index de08efe8..c712365f 100644
--- a/src/components/login/PasswordToken.jsx
+++ b/src/components/login/PasswordToken.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { Alert, Button, Form, Card } from "react-bootstrap";
 import HorizontalInput from "../HorizontalInput";
diff --git a/src/components/record/RecordController.jsx b/src/components/record/RecordController.jsx
index 48dfa32f..e2210a6e 100644
--- a/src/components/record/RecordController.jsx
+++ b/src/components/record/RecordController.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { injectIntl } from "react-intl";
 import withI18n from "../../i18n/withI18n";
diff --git a/src/components/record/RecordForm.jsx b/src/components/record/RecordForm.jsx
index b33f6056..01be3121 100644
--- a/src/components/record/RecordForm.jsx
+++ b/src/components/record/RecordForm.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import SForms, { Constants } from "@kbss-cvut/s-forms";
 import PropTypes from "prop-types";
diff --git a/src/components/record/RecordProvenance.jsx b/src/components/record/RecordProvenance.jsx
index 87e79443..217dd36b 100644
--- a/src/components/record/RecordProvenance.jsx
+++ b/src/components/record/RecordProvenance.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { FormattedMessage } from "react-intl";
 import { formatDate } from "../../utils/Utils";
diff --git a/src/components/record/RequiredAttributes.jsx b/src/components/record/RequiredAttributes.jsx
index 9a44c748..52e2ffe0 100644
--- a/src/components/record/RequiredAttributes.jsx
+++ b/src/components/record/RequiredAttributes.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 
 import HelpIcon from "../HelpIcon";
diff --git a/src/components/user/UserController.jsx b/src/components/user/UserController.jsx
index 658b98c9..917e9cfa 100644
--- a/src/components/user/UserController.jsx
+++ b/src/components/user/UserController.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { injectIntl } from "react-intl";
 import withI18n from "../../i18n/withI18n";
diff --git a/src/components/user/UsersController.jsx b/src/components/user/UsersController.jsx
index f8107225..0fc5436e 100644
--- a/src/components/user/UsersController.jsx
+++ b/src/components/user/UsersController.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import Routes from "../../constants/RoutesConstants";
 import { transitionToWithOpts } from "../../utils/Routing";
diff --git a/src/constants/Vocabulary.js b/src/constants/Vocabulary.js
index 170763a5..cf74f8cd 100644
--- a/src/constants/Vocabulary.js
+++ b/src/constants/Vocabulary.js
@@ -1,5 +1,3 @@
-"use strict";
-
 /**
  * Ontological vocabulary used by JSON-LD responses we get.
  */
diff --git a/src/index.jsx b/src/index.jsx
index b7da3a27..eb8fa22a 100644
--- a/src/index.jsx
+++ b/src/index.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { createRoot } from "react-dom/client";
 import { Provider } from "react-redux";
diff --git a/src/stores/I18nStore.js b/src/stores/I18nStore.js
index ba0aa6d6..a027f7bf 100644
--- a/src/stores/I18nStore.js
+++ b/src/stores/I18nStore.js
@@ -1,5 +1,3 @@
-"use strict";
-
 /**
  * Internationalization store for access from non-react components and objects.
  */
diff --git a/src/utils/DataFilter.js b/src/utils/DataFilter.js
index 6bb29c25..4f654d8d 100644
--- a/src/utils/DataFilter.js
+++ b/src/utils/DataFilter.js
@@ -1,5 +1,3 @@
-"use strict";
-
 /**
  * Filters data according to specified filter(s).
  *
diff --git a/src/utils/EntityFactory.js b/src/utils/EntityFactory.js
index 50cb95f7..71d5c994 100644
--- a/src/utils/EntityFactory.js
+++ b/src/utils/EntityFactory.js
@@ -1,5 +1,3 @@
-"use strict";
-
 import * as Utils from "./Utils";
 import * as RecordState from "../model/RecordState";
 import * as Vocabulary from "../constants/Vocabulary";
diff --git a/src/utils/Logger.js b/src/utils/Logger.js
index 387f05b6..dcde436c 100644
--- a/src/utils/Logger.js
+++ b/src/utils/Logger.js
@@ -1,5 +1,3 @@
-"use strict";
-
 export function log(msg) {
   console.log(msg);
 }
diff --git a/src/utils/Routes.jsx b/src/utils/Routes.jsx
index 79d2cf15..37de20d1 100644
--- a/src/utils/Routes.jsx
+++ b/src/utils/Routes.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 import React from "react";
 import { Redirect, Route, Switch } from "react-router-dom";
 import PasswordToken from "../components/login/PasswordToken";
diff --git a/src/utils/Routing.js b/src/utils/Routing.js
index 3aaf3c9c..c5f06ed0 100644
--- a/src/utils/Routing.js
+++ b/src/utils/Routing.js
@@ -1,5 +1,3 @@
-"use strict";
-
 import { execute } from "./RoutingRules";
 import { setTransitionPayload } from "../actions/RouterActions";
 import { createBrowserHistory } from "history";
diff --git a/src/utils/RoutingRules.js b/src/utils/RoutingRules.js
index 35d7d069..29980516 100644
--- a/src/utils/RoutingRules.js
+++ b/src/utils/RoutingRules.js
@@ -1,5 +1,3 @@
-"use strict";
-
 let rules = {};
 
 /**
diff --git a/src/utils/Utils.js b/src/utils/Utils.js
index f8eb9d06..2e15d3f1 100644
--- a/src/utils/Utils.js
+++ b/src/utils/Utils.js
@@ -1,4 +1,3 @@
-"use strict";
 import Bowser from "bowser";
 import * as Constants from "../constants/DefaultConstants";
 import { Constants as SConstants } from "@kbss-cvut/s-forms";
diff --git a/src/utils/injectIntl.js b/src/utils/injectIntl.js
index c6b186d0..54fdb396 100644
--- a/src/utils/injectIntl.js
+++ b/src/utils/injectIntl.js
@@ -1,5 +1,3 @@
-"use strict";
-
 import { injectIntl } from "react-intl";
 
 /**
diff --git a/src/validation/InstitutionValidator.jsx b/src/validation/InstitutionValidator.jsx
index 69000370..f2ea67df 100644
--- a/src/validation/InstitutionValidator.jsx
+++ b/src/validation/InstitutionValidator.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 export default class InstitutionValidator {
   static isValid(institution) {
     return !!institution.name;
diff --git a/src/validation/RecordValidator.jsx b/src/validation/RecordValidator.jsx
index 40a3dd33..867f32e6 100644
--- a/src/validation/RecordValidator.jsx
+++ b/src/validation/RecordValidator.jsx
@@ -1,4 +1,3 @@
-"use strict";
 import * as Constants from "../constants/DefaultConstants";
 
 export default class RecordValidator {
diff --git a/src/validation/UserValidator.jsx b/src/validation/UserValidator.jsx
index 86148c9c..e26443c2 100644
--- a/src/validation/UserValidator.jsx
+++ b/src/validation/UserValidator.jsx
@@ -1,5 +1,3 @@
-"use strict";
-
 export default class UserValidator {
   static isValid(user) {
     return user.firstName && user.lastName && user.username && user.emailAddress && user.institution;

From 8e5f2fb9d5429f68600cca505a3e7b1835480509 Mon Sep 17 00:00:00 2001
From: shellyear <boolevafunkce@gmail.com>
Date: Fri, 19 Apr 2024 19:37:16 +0500
Subject: [PATCH 2/5] [chore] add and apply eslint 'prefer-const' rule

---
 .eslintrc.cjs                                     | 3 +++
 src/actions/index.js                              | 2 +-
 src/components/history/HistoryList.jsx            | 2 +-
 src/components/history/HistoryRow.jsx             | 2 +-
 src/components/institution/Institution.jsx        | 2 +-
 src/components/institution/InstitutionMembers.jsx | 2 +-
 src/components/institution/InstitutionRow.jsx     | 2 +-
 src/components/institution/InstitutionTable.jsx   | 2 +-
 src/components/login/PasswordReset.jsx            | 2 +-
 src/components/login/PasswordToken.jsx            | 2 +-
 src/components/record/RecordRow.jsx               | 2 +-
 src/components/record/RecordTable.jsx             | 2 +-
 src/components/user/PasswordChange.jsx            | 2 +-
 src/components/user/User.jsx                      | 8 ++++----
 src/components/user/UserController.jsx            | 4 ++--
 src/components/user/UserRow.jsx                   | 2 +-
 src/components/user/UserTable.jsx                 | 2 +-
 src/utils/DataFilter.js                           | 4 ++--
 src/utils/Routing.js                              | 4 ++--
 src/utils/RoutingRules.js                         | 2 +-
 src/utils/Utils.js                                | 6 +++---
 21 files changed, 31 insertions(+), 28 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index cdc94a6c..54d1345e 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -8,6 +8,9 @@ module.exports = {
     },
   },
   plugins: ["react", "react-hooks"],
+  rules: {
+    "prefer-const": "warn", // Add prefer-const rule with warning level
+  },
   overrides: [
     {
       files: ["*.js", "*.jsx"], // Target all JSX files
diff --git a/src/actions/index.js b/src/actions/index.js
index cf8ef2b4..7531f72d 100644
--- a/src/actions/index.js
+++ b/src/actions/index.js
@@ -6,7 +6,7 @@ import { getOidcToken } from "../utils/SecurityUtils";
 import { isUsingOidcAuth } from "../utils/OidcUtils";
 
 // Axios instance for communicating with Backend
-export let axiosBackend = axios.create({
+export const axiosBackend = axios.create({
   withCredentials: true,
 });
 
diff --git a/src/components/history/HistoryList.jsx b/src/components/history/HistoryList.jsx
index 8974aa7b..d8bc6ca1 100644
--- a/src/components/history/HistoryList.jsx
+++ b/src/components/history/HistoryList.jsx
@@ -34,7 +34,7 @@ class HistoryList extends React.Component {
   };
 
   _handleChange = (e) => {
-    let change = {};
+    const change = {};
     change[e.target.name] = e.target.value;
     this.setState({ searchData: { ...this.state.searchData, ...change }, pageNumber: 1 });
   };
diff --git a/src/components/history/HistoryRow.jsx b/src/components/history/HistoryRow.jsx
index 001e3489..fa0e5298 100644
--- a/src/components/history/HistoryRow.jsx
+++ b/src/components/history/HistoryRow.jsx
@@ -4,7 +4,7 @@ import PropTypes from "prop-types";
 import { formatDateWithMilliseconds } from "../../utils/Utils";
 import { useI18n } from "../../hooks/useI18n";
 
-let HistoryRow = (props) => {
+const HistoryRow = (props) => {
   const { i18n } = useI18n();
   const action = props.action;
   const username = action.author ? action.author.username : i18n("history.non-logged");
diff --git a/src/components/institution/Institution.jsx b/src/components/institution/Institution.jsx
index 5d77e7a5..b5a74744 100644
--- a/src/components/institution/Institution.jsx
+++ b/src/components/institution/Institution.jsx
@@ -38,7 +38,7 @@ class Institution extends React.Component {
   }
 
   _onChange = (e) => {
-    let change = {};
+    const change = {};
     change[e.target.name] = e.target.value;
     this.props.handlers.onChange(change);
   };
diff --git a/src/components/institution/InstitutionMembers.jsx b/src/components/institution/InstitutionMembers.jsx
index 8700cb77..79947e2b 100644
--- a/src/components/institution/InstitutionMembers.jsx
+++ b/src/components/institution/InstitutionMembers.jsx
@@ -89,7 +89,7 @@ class InstitutionMembers extends React.Component {
 
   _renderRows() {
     const { institution, onEditUser, currentUser, userDeleted } = this.props;
-    let rows = [];
+    const rows = [];
     const members = this.props.institutionMembers.members;
     for (let i = 0, len = members.length; i < len; i++) {
       const deletionLoading = !!(
diff --git a/src/components/institution/InstitutionRow.jsx b/src/components/institution/InstitutionRow.jsx
index 34cdeec5..4ffb269e 100644
--- a/src/components/institution/InstitutionRow.jsx
+++ b/src/components/institution/InstitutionRow.jsx
@@ -5,7 +5,7 @@ import { Button } from "react-bootstrap";
 import { LoaderSmall } from "../Loader";
 import PropTypes from "prop-types";
 
-let InstitutionRow = (props) => {
+const InstitutionRow = (props) => {
   const institution = props.institution;
   return (
     <tr>
diff --git a/src/components/institution/InstitutionTable.jsx b/src/components/institution/InstitutionTable.jsx
index fb655c6a..57fa975f 100644
--- a/src/components/institution/InstitutionTable.jsx
+++ b/src/components/institution/InstitutionTable.jsx
@@ -80,7 +80,7 @@ class InstitutionTable extends React.Component {
   _renderRows() {
     const { institutions, institutionDeleted } = this.props;
     const onEdit = this.props.handlers.onEdit;
-    let rows = [];
+    const rows = [];
     for (let i = 0, len = institutions.length; i < len; i++) {
       rows.push(
         <InstitutionRow
diff --git a/src/components/login/PasswordReset.jsx b/src/components/login/PasswordReset.jsx
index 13a79caa..1cdc0118 100644
--- a/src/components/login/PasswordReset.jsx
+++ b/src/components/login/PasswordReset.jsx
@@ -29,7 +29,7 @@ class PasswordReset extends React.Component {
   }
 
   onChange = (e) => {
-    let state = this.state;
+    const state = this.state;
     state[e.target.name] = e.target.value;
     this.setState(state);
   };
diff --git a/src/components/login/PasswordToken.jsx b/src/components/login/PasswordToken.jsx
index c712365f..d6eeeddb 100644
--- a/src/components/login/PasswordToken.jsx
+++ b/src/components/login/PasswordToken.jsx
@@ -36,7 +36,7 @@ class PasswordReset extends React.Component {
   }
 
   onChange = (e) => {
-    let state = this.state;
+    const state = this.state;
     state[e.target.name] = e.target.value;
     this.setState(state);
   };
diff --git a/src/components/record/RecordRow.jsx b/src/components/record/RecordRow.jsx
index f3fca0d7..bb865d09 100644
--- a/src/components/record/RecordRow.jsx
+++ b/src/components/record/RecordRow.jsx
@@ -26,7 +26,7 @@ StatusInfo[RECORD_PHASE.REJECTED] = {
   tooltip: "records.completion-status-tooltip.rejected",
 };
 
-let RecordRow = (props) => {
+const RecordRow = (props) => {
   const { i18n } = useI18n();
   const record = props.record,
     formTemplateOptions = props.formTemplateOptions,
diff --git a/src/components/record/RecordTable.jsx b/src/components/record/RecordTable.jsx
index ec66a714..c5b5580e 100644
--- a/src/components/record/RecordTable.jsx
+++ b/src/components/record/RecordTable.jsx
@@ -108,7 +108,7 @@ class RecordTable extends React.Component {
     const formTemplateOptions = formTemplatesLoaded.formTemplates
       ? processTypeaheadOptions(formTemplatesLoaded.formTemplates, intl)
       : [];
-    let rows = [];
+    const rows = [];
     for (let i = 0, len = filteredRecords.length; i < len; i++) {
       rows.push(
         <RecordRow
diff --git a/src/components/user/PasswordChange.jsx b/src/components/user/PasswordChange.jsx
index ce6f5265..8089191f 100644
--- a/src/components/user/PasswordChange.jsx
+++ b/src/components/user/PasswordChange.jsx
@@ -28,7 +28,7 @@ class PasswordChange extends React.Component {
   }
 
   _onChange = (e) => {
-    let change = {};
+    const change = {};
     change[e.target.name] = e.target.value;
     this.props.handlers.onChange(change);
   };
diff --git a/src/components/user/User.jsx b/src/components/user/User.jsx
index 65ad08ae..084e9075 100644
--- a/src/components/user/User.jsx
+++ b/src/components/user/User.jsx
@@ -41,7 +41,7 @@ class User extends React.Component {
   }
 
   _onChange = (e) => {
-    let change = {};
+    const change = {};
     change[e.target.name] = e.target.value;
     this.props.handlers.onChange(change);
   };
@@ -57,7 +57,7 @@ class User extends React.Component {
 
   _onAdminStatusChange = (e) => {
     const role = e.target.value;
-    let types = this.props.user.types.slice();
+    const types = this.props.user.types.slice();
     if (role === ROLE.ADMIN) {
       types.push(Vocabulary.ADMIN_TYPE);
     } else {
@@ -67,11 +67,11 @@ class User extends React.Component {
   };
 
   _generateInstitutionsOptions = () => {
-    let options = [];
+    const options = [];
     const institutions = processInstitutions(this.props.institutions);
     const len = institutions.length;
     for (let i = 0; i < len; i++) {
-      let option = institutions[i];
+      const option = institutions[i];
       options.push(
         <option key={"opt_" + option.value} value={option.value}>
           {option.label}
diff --git a/src/components/user/UserController.jsx b/src/components/user/UserController.jsx
index 917e9cfa..c0f87a1f 100644
--- a/src/components/user/UserController.jsx
+++ b/src/components/user/UserController.jsx
@@ -97,7 +97,7 @@ class UserController extends React.Component {
   }
 
   _onSave = (sendEmail = true) => {
-    let user = this.state.user;
+    const user = this.state.user;
     this.setState({ saved: true, invited: false });
     if (user.isNew || (this._isNew() && this.props.userSaved.status === ACTION_STATUS.ERROR)) {
       this.props.createUser(omit(user, "isNew"));
@@ -133,7 +133,7 @@ class UserController extends React.Component {
   };
 
   _getPayload() {
-    let payload = this._isNew()
+    const payload = this._isNew()
       ? this.props.transitionPayload[Routes.createUser.name]
       : this.props.transitionPayload[Routes.editUser.name];
     this._isNew()
diff --git a/src/components/user/UserRow.jsx b/src/components/user/UserRow.jsx
index 0cf2d036..e85f23a7 100644
--- a/src/components/user/UserRow.jsx
+++ b/src/components/user/UserRow.jsx
@@ -4,7 +4,7 @@ import PropTypes from "prop-types";
 import IfInternalAuth from "../misc/oidc/IfInternalAuth";
 import { useI18n } from "../../hooks/useI18n";
 
-let UserRow = (props) => {
+const UserRow = (props) => {
   const user = props.user;
   const { i18n } = useI18n();
   return (
diff --git a/src/components/user/UserTable.jsx b/src/components/user/UserTable.jsx
index af67db2f..0e93544e 100644
--- a/src/components/user/UserTable.jsx
+++ b/src/components/user/UserTable.jsx
@@ -82,7 +82,7 @@ class UserTable extends React.Component {
   _renderUsers() {
     const { users } = this.props;
     const onEdit = this.props.handlers.onEdit;
-    let rows = [];
+    const rows = [];
     for (let i = 0, len = users.length; i < len; i++) {
       rows.push(<UserRow key={users[i].username} user={users[i]} onEdit={onEdit} onDelete={this._onDelete} />);
     }
diff --git a/src/utils/DataFilter.js b/src/utils/DataFilter.js
index 4f654d8d..717a0f0d 100644
--- a/src/utils/DataFilter.js
+++ b/src/utils/DataFilter.js
@@ -11,7 +11,7 @@ const filterData = (data, filter) => {
     return data;
   }
   return data.filter(function (item) {
-    for (let key in filter) {
+    for (const key in filter) {
       if (filter[key] === "all") {
         continue;
       }
@@ -35,7 +35,7 @@ const _canSkipFilter = (filter) => {
   if (!filter) {
     return true;
   }
-  for (let key in filter) {
+  for (const key in filter) {
     if (filter[key] !== "all") {
       return false;
     }
diff --git a/src/utils/Routing.js b/src/utils/Routing.js
index c5f06ed0..983ffd3d 100644
--- a/src/utils/Routing.js
+++ b/src/utils/Routing.js
@@ -14,7 +14,7 @@ export const history = createBrowserHistory({
  * @param route Route object
  */
 export function transitionTo(route) {
-  let path = route.path;
+  const path = route.path;
   execute(route.name);
   history.push({
     pathname: path,
@@ -51,7 +51,7 @@ export function transitionToWithOpts(route, options) {
 
 // TODO
 function setPathParams(path, params) {
-  for (let paramName in params) {
+  for (const paramName in params) {
     if (params.hasOwnProperty(paramName)) {
       path = path.replace(":" + paramName, params[paramName]);
     }
diff --git a/src/utils/RoutingRules.js b/src/utils/RoutingRules.js
index 29980516..6c415e94 100644
--- a/src/utils/RoutingRules.js
+++ b/src/utils/RoutingRules.js
@@ -1,4 +1,4 @@
-let rules = {};
+const rules = {};
 
 /**
  * Rules for each route is just an array of functions, that should be executed.
diff --git a/src/utils/Utils.js b/src/utils/Utils.js
index 2e15d3f1..9246b87a 100644
--- a/src/utils/Utils.js
+++ b/src/utils/Utils.js
@@ -85,9 +85,9 @@ export function constantToString(constant, capitalize) {
   if (!capitalize) {
     return constant.replace(/_/g, " ");
   }
-  let words = constant.split("_");
+  const words = constant.split("_");
   for (let i = 0, len = words.length; i < len; i++) {
-    let word = words[i];
+    const word = words[i];
     if (i > 0 && PREPOSITIONS.indexOf(word.toLowerCase()) !== -1) {
       words[i] = word.toLowerCase();
     } else {
@@ -224,8 +224,8 @@ export function getLastPathFragment(url) {
  * @return {number}
  */
 export function getStringHash(str) {
+  const srtlen = str ? str.length : 0;
   let hash = 0,
-    strlen = str ? str.length : 0,
     i,
     c;
   if (strlen === 0) {

From e6fb7bdcce5377f1e43b2bd6ae524f5c94af9195 Mon Sep 17 00:00:00 2001
From: shellyear <boolevafunkce@gmail.com>
Date: Fri, 19 Apr 2024 19:50:12 +0500
Subject: [PATCH 3/5] [chore] add and apply eslint 'prefer-arrow-callback' rule

---
 .eslintrc.cjs                      | 3 ++-
 src/components/HorizontalInput.jsx | 6 +++---
 src/components/Input.jsx           | 6 +++---
 src/utils/DataFilter.js            | 2 +-
 src/utils/Utils.js                 | 2 +-
 5 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 54d1345e..3edb93e8 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -9,7 +9,8 @@ module.exports = {
   },
   plugins: ["react", "react-hooks"],
   rules: {
-    "prefer-const": "warn", // Add prefer-const rule with warning level
+    "prefer-const": "warn",
+    "prefer-arrow-callback": "warn",
   },
   overrides: [
     {
diff --git a/src/components/HorizontalInput.jsx b/src/components/HorizontalInput.jsx
index 8a1eb455..a30cb2a5 100644
--- a/src/components/HorizontalInput.jsx
+++ b/src/components/HorizontalInput.jsx
@@ -4,7 +4,7 @@ import PropTypes from "prop-types";
 import Row from "react-bootstrap/Row";
 import TypeaheadAnswer from "./record/TypeaheadAnswer";
 
-const HorizontalInput = forwardRef(function HorizontalInputWithRef(props, ref) {
+const HorizontalInput = (props, ref) => {
   const renderInputOnType = () => {
     switch (props.type) {
       case "radio":
@@ -142,7 +142,7 @@ const HorizontalInput = forwardRef(function HorizontalInputWithRef(props, ref) {
   };
 
   return renderInputOnType();
-});
+};
 
 HorizontalInput.propTypes = {
   type: PropTypes.string,
@@ -167,4 +167,4 @@ HorizontalInput.defaultProps = {
   inputOffset: 4,
 };
 
-export default HorizontalInput;
+export default forwardRef(HorizontalInput);
diff --git a/src/components/Input.jsx b/src/components/Input.jsx
index 44d536ca..93a96116 100644
--- a/src/components/Input.jsx
+++ b/src/components/Input.jsx
@@ -2,7 +2,7 @@ import React, { forwardRef } from "react";
 import { FormLabel, FormGroup, FormControl, FormText, FormCheck } from "react-bootstrap";
 import PropTypes from "prop-types";
 
-const Input = forwardRef(function InputWithRef(props, ref) {
+const Input = (props, ref) => {
   const renderInputOnType = () => {
     switch (props.type) {
       case "radio":
@@ -78,7 +78,7 @@ const Input = forwardRef(function InputWithRef(props, ref) {
   };
 
   return renderInputOnType();
-});
+};
 
 Input.propTypes = {
   children: PropTypes.node.isRequired,
@@ -94,4 +94,4 @@ Input.defaultProps = {
   type: "text",
 };
 
-export default Input;
+export default forwardRef(Input);
diff --git a/src/utils/DataFilter.js b/src/utils/DataFilter.js
index 717a0f0d..7bcd13f1 100644
--- a/src/utils/DataFilter.js
+++ b/src/utils/DataFilter.js
@@ -10,7 +10,7 @@ const filterData = (data, filter) => {
   if (this._canSkipFilter(filter)) {
     return data;
   }
-  return data.filter(function (item) {
+  return data.filter((item) => {
     for (const key in filter) {
       if (filter[key] === "all") {
         continue;
diff --git a/src/utils/Utils.js b/src/utils/Utils.js
index 9246b87a..e41dbbda 100644
--- a/src/utils/Utils.js
+++ b/src/utils/Utils.js
@@ -250,7 +250,7 @@ export function getStringHash(str) {
 export function addParametersToUrl(url, parameters) {
   if (parameters) {
     url += URL_CONTAINS_QUERY.test(url) ? "&" : "?";
-    Object.getOwnPropertyNames(parameters).forEach(function (param) {
+    Object.getOwnPropertyNames(parameters).forEach((param) => {
       url += param + "=" + parameters[param] + "&"; // '&' at the end of request URI should not be a problem
     });
   }

From 6b97d4748f45f0d82be16ba6bdfab1752b7972d7 Mon Sep 17 00:00:00 2001
From: shellyear <boolevafunkce@gmail.com>
Date: Sat, 20 Apr 2024 03:28:47 +0500
Subject: [PATCH 4/5] [chore] add and apply all the recommended jsx-a11y rules

---
 .eslintrc.cjs     |  2 +-
 package-lock.json | 94 +++++++++++++++++++++++++++++++++++++++++++++++
 package.json      |  1 +
 3 files changed, 96 insertions(+), 1 deletion(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 3edb93e8..9e251bb4 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -1,6 +1,6 @@
 module.exports = {
   parser: "@babel/eslint-parser",
-  extends: ["plugin:react/recommended", "prettier"],
+  extends: ["plugin:react/recommended", "plugin:jsx-a11y/recommended", "prettier"],
   parserOptions: {
     requireConfigFile: false,
     babelOptions: {
diff --git a/package-lock.json b/package-lock.json
index d77a2ba6..1eca5da5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -51,6 +51,7 @@
         "dotenv-safe": "^8.2.0",
         "enzyme": "^3.11.0",
         "eslint-config-prettier": "^9.1.0",
+        "eslint-plugin-jsx-a11y": "^6.8.0",
         "eslint-plugin-react": "^7.34.0",
         "eslint-plugin-react-hooks": "^4.6.0",
         "husky": "^9.0.11",
@@ -2556,6 +2557,15 @@
         "sprintf-js": "~1.0.2"
       }
     },
+    "node_modules/aria-query": {
+      "version": "5.3.0",
+      "resolved": "https://registry.npmjs.org/aria-query/-/aria-query-5.3.0.tgz",
+      "integrity": "sha512-b0P0sZPKtyu8HkeRAfCq0IfURZK+SuwMjY1UXGBU27wpAiTwQAIlq56IbIO+ytk/JjS1fMR14ee5WBBfKi5J6A==",
+      "dev": true,
+      "dependencies": {
+        "dequal": "^2.0.3"
+      }
+    },
     "node_modules/array-buffer-byte-length": {
       "version": "1.0.1",
       "resolved": "https://registry.npmjs.org/array-buffer-byte-length/-/array-buffer-byte-length-1.0.1.tgz",
@@ -2773,6 +2783,12 @@
         "node": "*"
       }
     },
+    "node_modules/ast-types-flow": {
+      "version": "0.0.8",
+      "resolved": "https://registry.npmjs.org/ast-types-flow/-/ast-types-flow-0.0.8.tgz",
+      "integrity": "sha512-OH/2E5Fg20h2aPrbe+QL8JZQFko0YZaF+j4mnQ7BGhfavO7OpSLa8a0y9sBwomHdSbkhTS8TQNayBfnW5DwbvQ==",
+      "dev": true
+    },
     "node_modules/asynciterator.prototype": {
       "version": "1.0.0",
       "resolved": "https://registry.npmjs.org/asynciterator.prototype/-/asynciterator.prototype-1.0.0.tgz",
@@ -2837,6 +2853,15 @@
       "optional": true,
       "peer": true
     },
+    "node_modules/axe-core": {
+      "version": "4.7.0",
+      "resolved": "https://registry.npmjs.org/axe-core/-/axe-core-4.7.0.tgz",
+      "integrity": "sha512-M0JtH+hlOL5pLQwHOLNYZaXuhqmvS8oExsqB1SBYgA4Dk7u/xx+YdGHXaK5pyUfed5mYXdlYiphWq3G8cRi5JQ==",
+      "dev": true,
+      "engines": {
+        "node": ">=4"
+      }
+    },
     "node_modules/axios": {
       "version": "0.21.4",
       "resolved": "https://registry.npmjs.org/axios/-/axios-0.21.4.tgz",
@@ -2858,6 +2883,15 @@
         "axios": ">= 0.17.0"
       }
     },
+    "node_modules/axobject-query": {
+      "version": "3.2.1",
+      "resolved": "https://registry.npmjs.org/axobject-query/-/axobject-query-3.2.1.tgz",
+      "integrity": "sha512-jsyHu61e6N4Vbz/v18DHwWYKK0bSWLqn47eeDSKPB7m8tqMHF9YJ+mhIk2lVteyZrY8tnSj/jHOv4YiTCuCJgg==",
+      "dev": true,
+      "dependencies": {
+        "dequal": "^2.0.3"
+      }
+    },
     "node_modules/babel-plugin-macros": {
       "version": "3.1.0",
       "resolved": "https://registry.npmjs.org/babel-plugin-macros/-/babel-plugin-macros-3.1.0.tgz",
@@ -3853,6 +3887,12 @@
       "resolved": "https://registry.npmjs.org/csstype/-/csstype-3.1.3.tgz",
       "integrity": "sha512-M1uQkMl8rQK/szD0LNhtqxIPLpimGm8sOBwU7lLnCpSbTyY3yeU1Vc7l4KT5zT4s/yOxHH5O7tIuuLOCnLADRw=="
     },
+    "node_modules/damerau-levenshtein": {
+      "version": "1.0.8",
+      "resolved": "https://registry.npmjs.org/damerau-levenshtein/-/damerau-levenshtein-1.0.8.tgz",
+      "integrity": "sha512-sdQSFB7+llfUcQHUQO3+B8ERRj0Oa4w9POWMI/puGtuf7gFywGmkaLCElnudfTiKZV+NvHqL0ifzdrI8Ro7ESA==",
+      "dev": true
+    },
     "node_modules/dashdash": {
       "version": "1.14.1",
       "resolved": "https://registry.npmjs.org/dashdash/-/dashdash-1.14.1.tgz",
@@ -4165,6 +4205,12 @@
       "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.626.tgz",
       "integrity": "sha512-f7/be56VjRRQk+Ric6PmIrEtPcIqsn3tElyAu9Sh6egha2VLJ82qwkcOdcnT06W+Pb6RUulV1ckzrGbKzVcTHg=="
     },
+    "node_modules/emoji-regex": {
+      "version": "9.2.2",
+      "resolved": "https://registry.npmjs.org/emoji-regex/-/emoji-regex-9.2.2.tgz",
+      "integrity": "sha512-L18DaJsXSUk2+42pv8mLs5jJT2hqFkFE4j21wOmgbUqsZ2hL72NsUU785g9RXgo3s0ZNgVl42TiHp3ZtOv/Vyg==",
+      "dev": true
+    },
     "node_modules/entities": {
       "version": "4.5.0",
       "resolved": "https://registry.npmjs.org/entities/-/entities-4.5.0.tgz",
@@ -4537,6 +4583,36 @@
         "eslint": ">=7.0.0"
       }
     },
+    "node_modules/eslint-plugin-jsx-a11y": {
+      "version": "6.8.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-jsx-a11y/-/eslint-plugin-jsx-a11y-6.8.0.tgz",
+      "integrity": "sha512-Hdh937BS3KdwwbBaKd5+PLCOmYY6U4f2h9Z2ktwtNKvIdIEu137rjYbcb9ApSbVJfWxANNuiKTD/9tOKjK9qOA==",
+      "dev": true,
+      "dependencies": {
+        "@babel/runtime": "^7.23.2",
+        "aria-query": "^5.3.0",
+        "array-includes": "^3.1.7",
+        "array.prototype.flatmap": "^1.3.2",
+        "ast-types-flow": "^0.0.8",
+        "axe-core": "=4.7.0",
+        "axobject-query": "^3.2.1",
+        "damerau-levenshtein": "^1.0.8",
+        "emoji-regex": "^9.2.2",
+        "es-iterator-helpers": "^1.0.15",
+        "hasown": "^2.0.0",
+        "jsx-ast-utils": "^3.3.5",
+        "language-tags": "^1.0.9",
+        "minimatch": "^3.1.2",
+        "object.entries": "^1.1.7",
+        "object.fromentries": "^2.0.7"
+      },
+      "engines": {
+        "node": ">=4.0"
+      },
+      "peerDependencies": {
+        "eslint": "^3 || ^4 || ^5 || ^6 || ^7 || ^8"
+      }
+    },
     "node_modules/eslint-plugin-react": {
       "version": "7.34.0",
       "resolved": "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.34.0.tgz",
@@ -6649,6 +6725,24 @@
         }
       }
     },
+    "node_modules/language-subtag-registry": {
+      "version": "0.3.22",
+      "resolved": "https://registry.npmjs.org/language-subtag-registry/-/language-subtag-registry-0.3.22.tgz",
+      "integrity": "sha512-tN0MCzyWnoz/4nHS6uxdlFWoUZT7ABptwKPQ52Ea7URk6vll88bWBVhodtnlfEuCcKWNGoc+uGbw1cwa9IKh/w==",
+      "dev": true
+    },
+    "node_modules/language-tags": {
+      "version": "1.0.9",
+      "resolved": "https://registry.npmjs.org/language-tags/-/language-tags-1.0.9.tgz",
+      "integrity": "sha512-MbjN408fEndfiQXbFQ1vnd+1NoLDsnQW41410oQBXiyXDMYH5z505juWa4KUE1LqxRC7DgOgZDbKLxHIwm27hA==",
+      "dev": true,
+      "dependencies": {
+        "language-subtag-registry": "^0.3.20"
+      },
+      "engines": {
+        "node": ">=0.10"
+      }
+    },
     "node_modules/levn": {
       "version": "0.3.0",
       "resolved": "https://registry.npmjs.org/levn/-/levn-0.3.0.tgz",
diff --git a/package.json b/package.json
index 48b4ed10..05aa2cb4 100644
--- a/package.json
+++ b/package.json
@@ -49,6 +49,7 @@
     "dotenv-safe": "^8.2.0",
     "enzyme": "^3.11.0",
     "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-jsx-a11y": "^6.8.0",
     "eslint-plugin-react": "^7.34.0",
     "eslint-plugin-react-hooks": "^4.6.0",
     "husky": "^9.0.11",

From 4ac824826ba8073eddc06d2d27776d93d4b704f7 Mon Sep 17 00:00:00 2001
From: shellyear <boolevafunkce@gmail.com>
Date: Sat, 20 Apr 2024 04:00:57 +0500
Subject: [PATCH 5/5] [fix] apply all react-hooks recommended rules and fix
 eslint/exhaustive-deps warnings

---
 .eslintrc.cjs                             | 4 ++--
 src/App.jsx                               | 2 +-
 src/components/record/TypeaheadAnswer.jsx | 5 +++--
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 9e251bb4..2e4f3b51 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -1,13 +1,13 @@
 module.exports = {
   parser: "@babel/eslint-parser",
-  extends: ["plugin:react/recommended", "plugin:jsx-a11y/recommended", "prettier"],
+  extends: ["plugin:react/recommended", "plugin:jsx-a11y/recommended", "plugin:react-hooks/recommended", "prettier"],
   parserOptions: {
     requireConfigFile: false,
     babelOptions: {
       presets: ["@babel/preset-react"],
     },
   },
-  plugins: ["react", "react-hooks"],
+  plugins: ["react"],
   rules: {
     "prefer-const": "warn",
     "prefer-arrow-callback": "warn",
diff --git a/src/App.jsx b/src/App.jsx
index 0521a9d0..e88719d2 100644
--- a/src/App.jsx
+++ b/src/App.jsx
@@ -18,7 +18,7 @@ import PropTypes from "prop-types";
 const App = (props) => {
   useEffect(() => {
     document.title = APP_TITLE;
-  }, [APP_TITLE]);
+  }, []);
 
   return (
     <IntlProvider {...props.intl}>
diff --git a/src/components/record/TypeaheadAnswer.jsx b/src/components/record/TypeaheadAnswer.jsx
index 602f591e..1ae60458 100644
--- a/src/components/record/TypeaheadAnswer.jsx
+++ b/src/components/record/TypeaheadAnswer.jsx
@@ -24,9 +24,10 @@ export const processTypeaheadOptions = (options, intl) => {
   return JsonLdUtils.processTypeaheadOptions(options, intl);
 };
 
+const intl = { locale: "cs" };
+
 const TypeaheadAnswer = (props) => {
   // TODO
-  const intl = { locale: "cs" };
 
   const [isLoading, setLoading] = useState(true);
   const [options, setOptions] = useState(processTypeaheadOptions(props.options, intl));
@@ -38,7 +39,7 @@ const TypeaheadAnswer = (props) => {
         setOptions(processTypeaheadOptions(d, intl));
       });
     }
-  }, []);
+  }, [options.length, props.possibleValuesEndpoint]);
 
   const onOptionSelected = (option) => {
     const e = { target: { name: props.name, value: null } };