Refactor Validation

Signed-off-by: Atul Rajput <[email protected]>

Author: eatulrajput

flask-sqlite/app.py

@@ -7,6 +7,27 @@
 
 db.init_app(app)
 
+# 🔧 Validation Helper Function
+def validate_student_data(data, partial=False):
+    if not data:
+        return "Missing JSON body"
+
+    if not partial:
+        if 'name' not in data:
+            return "Missing 'name'"
+        if 'age' not in data:
+            return "Missing 'age'"
+
+    if 'name' in data:
+        if not isinstance(data['name'], str) or not data['name'].strip():
+            return "Invalid 'name'"
+
+    if 'age' in data:
+        if not isinstance(data['age'], int):
+            return "Invalid 'age'"
+
+    return None  # No error
+
 @app.route('/')
 def home():
     return jsonify({"message": "Flask Student API"}), 200
@@ -21,14 +42,9 @@ def get_students():
 @app.route('/students', methods=['POST'])
 def add_student():
     data = request.get_json()
-    
-    # Validation
-    if not data:
-        return jsonify({"error": "Missing JSON body"}), 400
-    if 'name' not in data or not isinstance(data['name'], str) or not data['name'].strip():
-        return jsonify({"error": "Invalid or missing 'name'"}), 400
-    if 'age' not in data or not isinstance(data['age'], int):
-        return jsonify({"error": "Invalid or missing 'age'"}), 400
+    error = validate_student_data(data)
+    if error:
+        return jsonify({"error": error}), 400
 
     student = Student(name=data['name'].strip(), age=data['age'])
     db.session.add(student)
@@ -39,17 +55,13 @@ def add_student():
 def update_student(id):
     student = Student.query.get_or_404(id)
     data = request.get_json()
+    error = validate_student_data(data, partial=True)
+    if error:
+        return jsonify({"error": error}), 400
 
-    # Validation
-    if not data:
-        return jsonify({"error": "Missing JSON body"}), 400
     if 'name' in data:
-        if not isinstance(data['name'], str) or not data['name'].strip():
-            return jsonify({"error": "Invalid 'name'"}), 400
         student.name = data['name'].strip()
     if 'age' in data:
-        if not isinstance(data['age'], int):
-            return jsonify({"error": "Invalid 'age'"}), 400
         student.age = data['age']
 
     db.session.commit()