Skip to content

Commit 8ff6175

Browse files
arndbkuba-moo
authored andcommitted
bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code
The CONFIG_DEFAULT_HUNG_TASK_TIMEOUT setting is only available when the hung task detection is enabled, otherwise the code now produces a build failure: drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: error: use of undeclared identifier 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT' 10188 | max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) { Enclose this warning logic in an #ifdef to ensure this builds. Fixes: 0fcad44 ("bnxt_en: Change FW message timeout warning") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Michael Chan <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 88922fe commit 8ff6175

File tree

1 file changed

+2
-0
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+2
-0
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+2
Original file line numberDiff line numberDiff line change
@@ -10184,11 +10184,13 @@ static int bnxt_hwrm_ver_get(struct bnxt *bp)
1018410184
if (!bp->hwrm_cmd_max_timeout)
1018510185
bp->hwrm_cmd_max_timeout = HWRM_CMD_MAX_TIMEOUT;
1018610186
max_tmo_secs = bp->hwrm_cmd_max_timeout / 1000;
10187+
#ifdef CONFIG_DETECT_HUNG_TASK
1018710188
if (bp->hwrm_cmd_max_timeout > HWRM_CMD_MAX_TIMEOUT ||
1018810189
max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {
1018910190
netdev_warn(bp->dev, "Device requests max timeout of %d seconds, may trigger hung task watchdog (kernel default %ds)\n",
1019010191
max_tmo_secs, CONFIG_DEFAULT_HUNG_TASK_TIMEOUT);
1019110192
}
10193+
#endif
1019210194

1019310195
if (resp->hwrm_intf_maj_8b >= 1) {
1019410196
bp->hwrm_max_req_len = le16_to_cpu(resp->max_req_win_len);

0 commit comments

Comments
 (0)