-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
Hey Kevin -- thank you for releasing this package, it has made my life much easier. One of the things my co-founder and I noticed is that checking for cycles with every new edge becomes a significant performance issue as DAGs grow larger (we could not build a graph with ~1,000 vertices and ~2,000 edges in a reasonable amount of time). I developed a tweak (check out my fork) where the user can choose to turn off cycle checking. Then, whenever an edge is added, the DAG "shuts off" and vertices and edges cannot be accessed until the user triggers a manual cycle checking.
It's working for our purposes but the code is messy and there are no tests -- is this something you want to merge into the main fork? If yes, let me know and I'll clean it up.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels