Simplify conditional setting of flag

tmadlener · tmadlener · commit ac29a36156b9 · 2025-10-27T15:56:38.000+01:00
diff --git a/k4FWCore/src/KeepDropSwitch.cpp b/k4FWCore/src/KeepDropSwitch.cpp
@@ -92,10 +92,9 @@ bool KeepDropSwitch::isOn(const std::string& astring) const {
 bool KeepDropSwitch::getFlag(const std::string& astring) const noexcept {
   bool flag = true;
   for (const auto& [cmd, pattern] : m_commandlines) {
-    bool match = wildcmp(pattern.c_str(), astring.c_str());
-    if (not match)
-      continue;
-    flag = (cmd == Cmd::KEEP);
+    if (wildcmp(pattern.c_str(), astring.c_str())) {
+      flag = (cmd == Cmd::KEEP);
+    }
   }
   return flag;
 }

Original file line number	Diff line number	Diff line change
`@@ -92,10 +92,9 @@ bool KeepDropSwitch::isOn(const std::string& astring) const {`
`92`	`92`	`bool KeepDropSwitch::getFlag(const std::string& astring) const noexcept {`
`93`	`93`	`bool flag = true;`
`94`	`94`	`for (const auto& [cmd, pattern] : m_commandlines) {`
`95`		`- bool match = wildcmp(pattern.c_str(), astring.c_str());`
`96`		`- if (not match)`
`97`		`- continue;`
`98`		`- flag = (cmd == Cmd::KEEP);`
	`95`	`+ if (wildcmp(pattern.c_str(), astring.c_str())) {`
	`96`	`+ flag = (cmd == Cmd::KEEP);`
	`97`	`+ }`
`99`	`98`	`}`
`100`	`99`	`return flag;`
`101`	`100`	`}`