-
Notifications
You must be signed in to change notification settings - Fork 29
Make KeepDropSwitch fail earlier on invalid inputs #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20b73e4 to
d057f2b
Compare
|
A quick benchmark shows that the interesting use case of constructing the It is not the most performance sensitive piece in the whole chain, but I think it is still nice to see that the pre-processing we do in the constructor pays off for the overall runtime. |
|
Yes, I don't think any difference will be noticeable, at least I never saw it in profiles. I think the unnamespaced one can be removed, I don't think it is used anywhere else. |
ac29a36 to
414cedf
Compare
Make things fail as early as possible and avoid re-parsing command lines over and over again (even if we call it at most once per collection from IOSvc). This has the nice side-benefit of making it possible to fail in initialize already.
414cedf to
8b731ea
Compare
Used e.g. by muon collider for the moment
|
I'm not sure for how long Gaudi will be buildable with GCC 11 since it has been a while they only test with GCC 13 and above. |
BEGINRELEASENOTES
KeepDropSwitchin the constructor instead of re-parsing them every timeisOnis called.KeepDropSwitchinto thek4FWCorenamespace and deprecate the unnamespaced usage.IOSvcfail ininitializein case theoutputCommandsare invalidKeepDropSwitchENDRELEASENOTES
Not sure if the deprecation of the global namespace definition of
KeepDropSwitchis necessary or if we can simply remove the deprecated definition immediately.Fixes #348