Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on go-multierror #10643

Open
jenshu opened this issue Feb 17, 2025 · 3 comments
Open

remove dependency on go-multierror #10643

jenshu opened this issue Feb 17, 2025 · 3 comments

Comments

@jenshu
Copy link
Contributor

jenshu commented Feb 17, 2025

Broken out from a PR comment #10632 (comment)

We should rip this dependency out in favor of other methods for aggregating errors together (e.g. utilerrors.NewAggregate or the stlib errors.Join).
@jenshu jenshu mentioned this issue Feb 17, 2025
Merged
@lgadban
Copy link
Contributor

lgadban commented Feb 17, 2025

can we consolidate this issue with #10516?
If that doesn't make sense, we should track this under the cleanup epic: #10496

@timflannagan
Copy link
Member

Moving it under the cleanup epic SGTM.

@jenshu
Copy link
Contributor Author

jenshu commented Feb 18, 2025

sure, added as a sub-issue of #10496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Kgateway Planning
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgadban @timflannagan @jenshu