Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kgateway service name can get out of sync between helm vs code #10659

Open
jenshu opened this issue Feb 19, 2025 · 0 comments · May be fixed by #10666
Open

kgateway service name can get out of sync between helm vs code #10659

jenshu opened this issue Feb 19, 2025 · 0 comments · May be fixed by #10666
Assignees
@jenshu
Milestone
kgateway v2.0.0-b...

Comments

@jenshu
Copy link
Contributor

jenshu commented Feb 19, 2025

The kgateway control plane service name is currently overridable in the helm chart, but in our controller it's hardcoded and assumed to be kgateway. As a short-term fix we should hardcode it to kgateway in the helm chart as well.

As a follow-up, we can consider making it configurable again - see #10658
@jenshu jenshu self-assigned this Feb 19, 2025
@jenshu jenshu moved this from Backlog to In progress in Kgateway Planning Feb 19, 2025
@jenshu jenshu linked a pull request Feb 19, 2025 that will close this issue
Open
@lgadban lgadban added this to the kgateway v2.0.0-beta1 milestone Feb 19, 2025
@jenshu jenshu moved this from In progress to In review in Kgateway Planning Feb 19, 2025
@lgadban lgadban moved this from In review to In progress in Kgateway Planning Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenshu jenshu

Labels
None yet
Projects
Kgateway Planning
Status: In progress
Milestone
kgateway v2.0.0-beta1
Development

Successfully merging a pull request may close this issue.

Hardcode kgateway service name jenshu/kgateway
2 participants
@lgadban @jenshu