Optimize ResourceList.Find to use map instead of list

[sam-heilbron]

Gloo Edge Product

Open Source

Gloo Edge Version

1.17

Is your feature request related to a problem? Please describe.

When the scale of resources that are being managed by the Control-Plane grows, the performance of the translation loop degrades. One way to handle a higher cardinality of resources, is by relying on lists of resources which are indexed once at the beginning of the translation loop.

At the moment, you can see https://github.com/solo-io/gloo/blob/main/projects/gloo/pkg/api/v1/upstream.sk.go#L71 as an example: we iterate over the resources each time we need to Find an element.

Describe the solution you'd like

• Index once at the beginning of translation, or lazily the first time that a resource is requested
• Measure the performance impact before and after
• Identify if there are situations where relying on a list is actually better than a map
• Confirm that translation is idempotent and ordering doesn't become a problem since maps don't guarantee order constraints

Describe alternatives you've considered

No response

Additional Context

Identical request to: solo-io/solo-kit#521

[github-actions]

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.