Inaccurate error message for invalid add order command

[ki1r0]

##Description
Inaccurate error message for invalid add order command.
The error message is
The index provided is out of range.
Please make sure the the index refers to a valid client, pastry or order in the current list shown.
However the order Index is correct. This does not help the user in knowing where he got the input wrong.

##Steps to reproduce
add order 1 -p Croissant -q 2 -pn Tart -q2

##Expected
error message of invalid command format as the first prefix is wrong.

##Actual
The index provided is out of range.
Please make sure the the index refers to a valid client, pastry or order in the current list shown.

##Screenshots

[nus-pe-script]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for pointing out this bug!

Assessment

However, this seem to be a duplicate of another issue #932 where there is a bug regarding the add order parser displaying an inaccurate error message. We have marked this as a duplicate since fixing the parser will fix both issues

The severity follows the severity of the duplicate as it only causes a minor inconvenience to users. The add order command still functions perfectly and follows the format provided in UG.

Conclusion

Due to the similarity of the issue which highlights the inaccuracy of error message displayed on add order, this has been marked as a duplicate of issue #932.
Thanks for helping us improve PowerBake!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inaccurate error message for add order

##Description
the error message for invalid add order command is inaccurate

##Steps to reproduce
add order 1 -pn Croissant -q 2 -pn Apple Pie -q 2 -pn

##Expected
as the name of the last bakery is not specified, the error message should be warning that says bakery name not specified, or invalid format, or missing parameter etc

##Actual
error message:
Quantity must be a positive integer between 1 - 999

##Screenshots

---

_{[original: nus-cs2103-AY2425S2/pe-interim#597] [original labels: type.FunctionalityBug severity.Low]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, Thank you for pointing out this bug!

Assessment

Our team has certainly miss out in noticing this bug. The bug seems to be from the add order parser. We believe, it is unlikely to cause much inconvenience to our users and therefore we agree with the low severity of this bug.

Conclusion

Thanks for helping us improve PowerBake!

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• I disagree

Reason for disagreement: Thank you for your response.

However, I respectfully disagree with the classification of this issue as a duplicate of issue #932. While both bugs are indeed related to the add order command and are caused by errors in the parser, they arise from different sections of the parsing logic, leading to distinct parsing processes and error messages.

If these two bugs were caused by the same section of code, I'd certainly agree that they are duplicates. However, in this case, it is clear that one issue stems from an invalid prefix format (e.g., -q2 instead of -q 2), while the other stems from a missing parameter value after a valid prefix. These are separate problems that require attention in different areas of the code.

Although a fix in the parser may resolve both, treating them as the same issue may overlook the need to validate multiple input handling paths.

Therefore, I believe these issues should be tracked separately to ensure both aspects of the parser are addressed properly.

Thank you again for your attention to this!

---