Skip to content

cargo clippy outputs several collapsible_if warnings #948

@zacknewman

Description

@zacknewman

The only error/warning that is currently triggered by cargo clippy is collapsible_if. Seeing how that is the only error/warning, I'm inclined to believe that cargo clippy is run as part of some CI process. Does it make sense to address those warnings or allow/expect them on a case-by-case basis? allow that lint in Cargo.toml?

Example:

warning: this `if` statement can be collapsed
   --> src/bin/upgrade/upgrade.rs:850:13
    |
850 | /             if let Some(old_version_req) = &self.old_version_req {
851 | |                 if let Ok(old_version_req) = VersionReq::parse(old_version_req) {
852 | |                     return old_version_req.matches(&latest_version);
853 | |                 }
854 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
help: collapse nested if block
    |
850 ~             if let Some(old_version_req) = &self.old_version_req
851 ~                 && let Ok(old_version_req) = VersionReq::parse(old_version_req) {
852 |                     return old_version_req.matches(&latest_version);
853 ~                 }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions