Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions used in ERROR call should be subclass of class ERROR #17

Open
Yehouda opened this issue Dec 13, 2024 · 0 comments
Open

Conditions used in ERROR call should be subclass of class ERROR #17

Yehouda opened this issue Dec 13, 2024 · 0 comments

Comments

@Yehouda
Copy link

Yehouda commented Dec 13, 2024

(define-condition illegal-opcode ()

The conditions in this file are defined without a parenty-type, they are direct subclass of condition. That means that error handlers (for example ignore-errors), which expect a condition of type error, don't handle these conditions.
They all should be made to inherit from error, e.g.

(define-condition illegal-opcode (error)
   ....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant