Version 1.6. This update fixes a crash that can occur if authentication with the Google presentation API fails. It also adds support for caching the previously retrieved MMR/league/race information from the Blizzard API so that if it goes down, BeefBot remembers the last values and can still display them.

Author: kirby561

Beef/Application.cs

@@ -10,7 +10,7 @@
 
 namespace Beef {
     class Application : ProfileInfoProvider, MmrListener {
-        private readonly String _version = "1.5";
+        private readonly String _version = "1.6";
         private BeefConfig _config;
         private String _botPrefix;
         private BeefUserConfigManager _userManager;
@@ -694,8 +694,28 @@ public void OnMmrRead(List<Tuple<ProfileInfo, LadderInfo>> mmrList) {
                     if (user == null)
                         continue;
 
+                    // If the LadderInfo for a user is null, we failed to update their information.
+                    // In this case, use the last known values so they are still displayed.
+                    Tuple<ProfileInfo, LadderInfo> mmrDictionaryEntry = entry;
+                    if (entry.Item2 == null) {
+                        // Also make sure we have a previous MMR to show
+                        // If there isn't, leave it null so it displays correctly.
+                        if (!String.IsNullOrEmpty(user.LastKnownMmr)) {
+                            LadderInfo previousInfo = new LadderInfo();
+                            previousInfo.League = user.LastKnownLeague;
+                            previousInfo.Mmr = user.LastKnownMmr;
+                            previousInfo.Race = user.LastKnownMainRace;
+
+                            mmrDictionaryEntry = new Tuple<ProfileInfo, LadderInfo>(entry.Item1, previousInfo);
+                        }
+                    } else {
+                        // If the update was successful, record it for later too.
+                        // (Note: Should this be done on the MMR reading thread? Seems silly to block the main context for this.)
+                        _userManager.UpdateUserLadderInfo(user.BeefName, entry.Item2);
+                    }
+
                     if (!profileIdToMaxMmrDict.ContainsKey(user.BeefName))
-                        profileIdToMaxMmrDict.Add(user.BeefName, entry);
+                        profileIdToMaxMmrDict.Add(user.BeefName, mmrDictionaryEntry);
                     else
                         Console.WriteLine("Warning: User " + user.BeefName + " already exists in the profileIdToMaxMmrDict!");
                 }

Beef/BeefUserConfig.cs

@@ -7,7 +7,7 @@ namespace Beef {
     /// </summary>
     class BeefUserConfig {
         // This is the current version and should always be incremented when changing the config file format.
-        public static int BeefUserVersion = 0;
+        public static int BeefUserVersion = 1;
 
         // This is the persisted version so we know if it's not the latest when we start up.
         public int Version = BeefUserVersion;
@@ -16,6 +16,11 @@ class BeefUserConfig {
         public String BeefName = ""; // This is the name that is displayed on the Beef ladder. It must be unique on the ladder.
         public String DiscordName = ""; // This is the discord name including the #1234 tag.
 
+        // Save previous MMR information in case the servers go down
+        public String LastKnownMmr = "";
+        public String LastKnownMainRace = "";
+        public String LastKnownLeague = "";
+
         public ProfileInfo ProfileInfo = null; // This is information about their profile so we can update their MMR.
 
         public BeefUserConfig(String beefName, String discordName) {
@@ -26,6 +31,9 @@ public BeefUserConfig(String beefName, String discordName) {
         public BeefUserConfig(BeefUserConfig other) {
             BeefName = other.BeefName;
             DiscordName = other.DiscordName;
+            LastKnownMmr = other.LastKnownMmr;
+            LastKnownMainRace = other.LastKnownMainRace;
+            LastKnownLeague = other.LastKnownLeague;
 
             if (other.ProfileInfo != null)
                 ProfileInfo = new ProfileInfo(other.ProfileInfo);

Beef/BeefUserConfigManager.cs

@@ -1,4 +1,5 @@
-using System;
+using Beef.MmrReader;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Text.RegularExpressions;
@@ -126,6 +127,23 @@ public BeefUserConfig GetUserByDiscordId(String discordId) {
             }
         }
 
+        /// <summary>
+        /// Updates the last known ladder information for a given beef user.
+        /// </summary>
+        /// <param name="beefName">The user's beef name.</param>
+        /// <param name="ladderInfo">The ladder info for the user.</param>
+        /// <returns>Returns ErrorCode.Success if it succeeded, otherwise an error indicating the problem.</returns>
+        public ErrorCode UpdateUserLadderInfo(String beefName, LadderInfo ladderInfo) {
+            lock (_userConfigsLock) {
+                BeefUserConfig user = _userNameToBeefConfigMap[beefName];
+                user.LastKnownLeague = ladderInfo.League;
+                user.LastKnownMmr = ladderInfo.Mmr;
+                user.LastKnownMainRace = ladderInfo.Race;
+                ErrorCode error = WriteBeefUserToFile(user, GetBeefUserFilePath(user.BeefName));
+                return error;
+            }
+        }
+
         /// <summary>
         /// Links the given beef name to the given battle.net account.
         /// </summary>