Skip to content

Writing DataSetEntity using ZipWriter does not set its file name to its ID #254

@Pfeil

Description

@Pfeil

There is a bug where dataset entities would not adjust their names given the CrateWriter (and the not yet released CrateWriter).

This is being worked on in #253 and will land in the next release (v2.1.0, which will likely a release candidate for a short while).

You may be affected if all of these points apply to you (more context below):

  • You used a ZipWriter AND
  • used a DataSetEntitiy in the crate WHICH
  • had one of its setLocation*(...) methods called AND
  • had a different ID (setId(...)) than the filename given to setLocation*(...)

Context:

The fix also improves the documentation on this. But for reference: The setLocation*(...) methods give a data(set) entity a location to a file associated with it. This file will then be copied into the crate when writing the crate with a Writer.

This worked fine for the folder writer (a Writer with a FolderStrategy). But it was not working (and not tested for) the ZipWriter. The fix also unifies this (and all other) tests to be applied to all writers to ensure this is not going to happen again.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions