Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multi-View: Hide overall measure navigation if measure information #1490

Open
markusweigelt opened this issue Feb 13, 2025 · 3 comments
Assignees
Labels
🐛 bug A non-security related bug.

Comments

@markusweigelt
Copy link
Contributor

markusweigelt commented Feb 13, 2025

Description

The measure navigation in multiview can be hidden if measure information is not available for every document.

Reproduction

Steps to reproduce the behaviour:

  1. Navigate to:
    https://example.com/viewer?tx_dlf%5Baction%5D=main&tx_dlf%5Bcontroller%5D=PageView&tx_dlf%5BdocPage%5D%5B1%5D=5&tx_dlf%5BdocPage%5D%5B2%5D=9&tx_dlf%5BdocPage%5D%5B3%5D=13&tx_dlf%5BdocPage%5D%5B4%5D=15&tx_dlf%5Bdouble%5D=0&tx_dlf%5Bid%5D=https%3A%2F%2Ftest.dfg-viewer.de%2Ffileadmin%2Fcomposition%2FMus.2389-N-9.xml&tx_dlf%5Bmultiview%5D=1&tx_dlf%5Bpage%5D=1&cHash=519b78c80be30d359759090f71db9599

Expected Behavior

Forward measure navigation is hidden if at least one of the documents has no measure to navigate forward. The same applies to backward navigation.

Screenshots and Examples

Image

Environment

  • TYPO3 version: [e.g. 11.5.41]
@markusweigelt markusweigelt added the 🐛 bug A non-security related bug. label Feb 13, 2025
@sebastian-meyer
Copy link
Member

sebastian-meyer commented Feb 13, 2025

I disagree with removing those buttons. It does make sense to browse to the next page or measure for all views at once (instead of having to do this for every view individually).

But the buttons for navigating by measures should only be visible when there actually is measure-information available for every viewed document, of course.

@markusweigelt
Copy link
Contributor Author

Exactly, I accidentally selected too much. I'll adjust the screenshot.

@markusweigelt markusweigelt changed the title [BUG] Multi-View: Hide overall measure navigation [BUG] Multi-View: Hide overall measure navigation if measure information is not available for every documents Feb 13, 2025
@markusweigelt markusweigelt changed the title [BUG] Multi-View: Hide overall measure navigation if measure information is not available for every documents [BUG] Multi-View: Hide overall measure navigation if measure information is not available for every document Feb 13, 2025
@markusweigelt markusweigelt changed the title [BUG] Multi-View: Hide overall measure navigation if measure information is not available for every document [BUG] Multi-View: Hide overall measure navigation if measure information Feb 13, 2025
@markusweigelt
Copy link
Contributor Author

Description of issue is also updated. That should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

No branches or pull requests

3 participants