-
Notifications
You must be signed in to change notification settings - Fork 327
Remove python long to support Cython >= 3.1.x #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All failures are Pypy 3.8, which Cython 3.1 may not support? |
I don't remember if it does or not off the top of my head, but I don't think anything in this change should need Cython 3.1. On earlier versions of Cython, |
We already looked at this in #752: see #753 (comment) |
CC: @misl6 |
|
Hi @cmacdonald, I've just pushed some changes that should fix the CI/CD pipeline, can you please rebase on top of master? |
|
rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
|
@T-Dynamos + @cmacdonald , I guess we're only missing Python 3.13 support (and maybe Cython < 3) removal to process a release? |
|
@misl6 Yes, I believe this is ready for release. I've also tested this PR on Android. |
In #753 (comment) it was suggested by @da-woods that the fix for #753 was sub-optimal:
This PR:
ctypes.c_longdebugkwarg for method and constructor invocation that displays the scores of the different methods that are being scored incalculate_scores(). This may be useful when use of thesignaturekwarg is necessary.Example output:
(ie. constructors (I)V and (J)V both got score of 20, jnius selected (J)V.