Skip to content

The errors in update-codegen.sh are silenced #342

@cardil

Description

@cardil

[[ ! -f hack/update-codegen.sh ]] || ./hack/update-codegen.sh

This line is probably buggy. In shell, if the whole line will be evaluated as conditional, and conditionals doesn't fail the script.

It most likely should be:

if [[ ! -f hack/update-codegen.sh ]]; then
  ./hack/update-codegen.sh
fi

/kind bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions