-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Description
The script excludes diff in go.mod, go.sum and modules.txt:
so update-deps bot does not create the PR even when deps have diff - e.g. https://github.com/knative-sandbox/knobots/runs/2523678545?check_suite_focus=true did not create PR (please check in Apply work)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: go.mod
modified: go.sum
modified: vendor/modules.txt
This is no problem in general as it is just a module name change. But it causes an error in Verify Deps and Codegen actions.
(e.g.) https://github.com/knative-sandbox/net-kourier/pull/509/checks?check_run_id=2515042767
Now I am wondering if update-deps bot should create the PR or .github/workflows/knative-verify.yaml should exclude the module name diff.
Metadata
Metadata
Assignees
Labels
No labels