Skip to content

update-deps bot does not send PR for only module diff #82

@nak3

Description

@nak3

The script excludes diff in go.mod, go.sum and modules.txt:

https://github.com/knative-sandbox/knobots/blob/05c5158e8da094a33d708fd7c7d504faed62ca3b/actions/update-deps/entrypoint.sh#L59-L70

so update-deps bot does not create the PR even when deps have diff - e.g. https://github.com/knative-sandbox/knobots/runs/2523678545?check_suite_focus=true did not create PR (please check in Apply work)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   go.mod
	modified:   go.sum
	modified:   vendor/modules.txt

This is no problem in general as it is just a module name change. But it causes an error in Verify Deps and Codegen actions.

(e.g.) https://github.com/knative-sandbox/net-kourier/pull/509/checks?check_run_id=2515042767

Now I am wondering if update-deps bot should create the PR or .github/workflows/knative-verify.yaml should exclude the module name diff.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions