Skip to content

Commit 088caf3

Browse files
upgrade to latest dependencies (#960)
bumping knative.dev/pkg 4ffdcf6...077dcf0: > 077dcf0 [release-1.19] [controller] fix depth metrics (# 3254) > 9aa1144 upgrade to latest dependencies (# 3243) Signed-off-by: Knative Automation <[email protected]>
1 parent ee61fe0 commit 088caf3

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
k8s.io/code-generator v0.33.4
1212
k8s.io/kube-openapi v0.0.0-20250318190949-c8a335a9a2ff
1313
knative.dev/hack v0.0.0-20250902154142-af735b2738d6
14-
knative.dev/pkg v0.0.0-20250821143151-4ffdcf6b3fa5
14+
knative.dev/pkg v0.0.0-20250909011231-077dcf0d00e8
1515
)
1616

1717
require (

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,8 @@ k8s.io/utils v0.0.0-20241210054802-24370beab758 h1:sdbE21q2nlQtFh65saZY+rRM6x6aJ
186186
k8s.io/utils v0.0.0-20241210054802-24370beab758/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
187187
knative.dev/hack v0.0.0-20250902154142-af735b2738d6 h1:JYZgO9bni32T+BB5v6WpeRFm1hjj+EypBLZCk6HZBt0=
188188
knative.dev/hack v0.0.0-20250902154142-af735b2738d6/go.mod h1:R0ritgYtjLDO9527h5vb5X6gfvt5LCrJ55BNbVDsWiY=
189-
knative.dev/pkg v0.0.0-20250821143151-4ffdcf6b3fa5 h1:2U4nNoTuF/3enFcPp1BVQXCjUC4XfieIHkZeuU7j8uA=
190-
knative.dev/pkg v0.0.0-20250821143151-4ffdcf6b3fa5/go.mod h1:ewap/fhCZCh6Gm+F6udBION8T2+UcJFK4L1Ss/5K8Dw=
189+
knative.dev/pkg v0.0.0-20250909011231-077dcf0d00e8 h1:n0BMHXIem9MyDkK4vfA4Vzdxaf1e+EeLJ6k+8exCjjI=
190+
knative.dev/pkg v0.0.0-20250909011231-077dcf0d00e8/go.mod h1:a1amDzo4YIUNuGeDgEz/uDHs5MQVYI1DXnRnEpWCAts=
191191
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
192192
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
193193
sigs.k8s.io/randfill v0.0.0-20250304075658-069ef1bbf016/go.mod h1:XeLlZ/jmk4i1HRopwe7/aU3H5n1zNUcX6TM94b3QxOY=

vendor/knative.dev/pkg/controller/queue_metrics.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,15 @@ func (m *queueMetrics) get(item any) {
8888
m.mu.Lock()
8989
defer m.mu.Unlock()
9090

91-
m.depth.Dec()
92-
m.processingStartTimes[item] = m.clock.Now()
93-
9491
if startTime, exists := m.addTimes[item]; exists {
92+
m.depth.Dec()
9593
m.latency.Observe(m.sinceInSeconds(startTime))
9694
delete(m.addTimes, item)
9795
}
96+
97+
if _, exists := m.processingStartTimes[item]; !exists {
98+
m.processingStartTimes[item] = m.clock.Now()
99+
}
98100
}
99101

100102
func (m *queueMetrics) done(item any) {

vendor/knative.dev/pkg/controller/two_lane_queue.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,9 @@ func (q *twoLaneRateLimitingQueue) slowLane() workqueue.TypedInterface[any] {
223223
// It gets the item from fast lane if it has anything, alternatively
224224
// the slow lane.
225225
func (tlq *twoLaneQueue) Get() (any, bool) {
226-
item, ok := tlq.consumerQueue.Get()
226+
item, shutdown := tlq.consumerQueue.Get()
227227
tlq.metrics.get(item)
228-
return item, ok
228+
return item, shutdown
229229
}
230230

231231
// Len returns the sum of lengths.

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ k8s.io/utils/trace
721721
# knative.dev/hack v0.0.0-20250902154142-af735b2738d6
722722
## explicit; go 1.21
723723
knative.dev/hack
724-
# knative.dev/pkg v0.0.0-20250821143151-4ffdcf6b3fa5
724+
# knative.dev/pkg v0.0.0-20250909011231-077dcf0d00e8
725725
## explicit; go 1.24.0
726726
knative.dev/pkg/apis
727727
knative.dev/pkg/apis/duck

0 commit comments

Comments
 (0)