Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ArgoCD to deploy cluster manifests instead of kubectl #3363

Closed
upodroid opened this issue Jun 3, 2022 · 1 comment · Fixed by #3399
Closed

Switch to using ArgoCD to deploy cluster manifests instead of kubectl #3363

upodroid opened this issue Jun 3, 2022 · 1 comment · Fixed by #3399
Labels
area/prow Issues or PRs related to Prow configuration kind/enhancement priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@upodroid
Copy link
Member

upodroid commented Jun 3, 2022

When changes to the cluster configuration is made, a prow postsubmit job runs kubectl apply -f prow/cluster/build to deploy the config, but this problematic for a few reasons:

# Random Example
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: certmanager-prod
  namespace: argocd
spec:
  destination:
    namespace: cert-manager
    name: prod
  project: default
  source:
    chart: cert-manager
    helm:
      parameters:
      - name: installCRDs
        value: "true"
      releaseName: cert-manager
    repoURL: https://charts.jetstack.io
    targetRevision: v1.6.1
  syncPolicy:
    automated:
      prune: true
      selfHeal: true
    syncOptions:
    - CreateNamespace=true
  • Updating third party tools loaded via Helm will be simpler in addition to leaner config.

/cc @kvmware

If we are happy with this, let me know and i'll bootstrap argocd in the prow cluster.

@dprotaso
Copy link
Member

dprotaso commented Jun 6, 2022

just an FYI

  1. kubectl has prune support
  2. In serving we use kapp cli which is like a smarter kubectl - that solves ordering and waiting without the extra infrastructure

that's all I have - haven't used Argo myself so I'm neutral

@upodroid upodroid moved this to In Design/Discussion in Infra (Productivity) Jun 6, 2022
@upodroid upodroid added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/prow Issues or PRs related to Prow configuration labels Jun 7, 2022
@krsna-m krsna-m moved this from In Design/Discussion to Ready To Work in Infra (Productivity) Jun 15, 2022
Repository owner moved this from Ready To Work to Done in Infra (Productivity) Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to Prow configuration kind/enhancement priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants