no need for the constructor if it just calls super

knzai · knzai · commit f631f1fe4f56 · 2024-08-10T01:25:05.000-07:00
diff --git a/src/webc/file-byte-reader.js b/src/webc/file-byte-reader.js
@@ -1,7 +1,4 @@
 class FileByteReader extends HTMLInputElement {
-  constructor() {
-    super();
-  }
   connectedCallback() {
     this.addEventListener('change', this.onChange);
   }
@@ -16,6 +13,7 @@ class FileByteReader extends HTMLInputElement {
   }
 
   onChange() {
+    if (this.files.length == 0) { return }
     const fileReader = new FileReader();
     fileReader.addEventListener('loadend', e => this.emit('loaded', new Int8Array(fileReader.result)));
     fileReader.readAsArrayBuffer(this.files[0]);

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`	`1`	`class FileByteReader extends HTMLInputElement {`
`2`		`- constructor() {`
`3`		`- super();`
`4`		`- }`
`5`	`2`	`connectedCallback() {`
`6`	`3`	`this.addEventListener('change', this.onChange);`
`7`	`4`	`}`
`@@ -16,6 +13,7 @@ class FileByteReader extends HTMLInputElement {`
`16`	`13`	`}`
`17`	`14`
`18`	`15`	`onChange() {`
	`16`	`+ if (this.files.length == 0) { return }`
`19`	`17`	`const fileReader = new FileReader();`
`20`	`18`	`fileReader.addEventListener('loadend', e => this.emit('loaded', new Int8Array(fileReader.result)));`
`21`	`19`	`fileReader.readAsArrayBuffer(this.files[0]);`