Don't allow both --fingerprint and --artifact-type flags to be used

Author: FayeSGW

cmd/kosli/assertApproval.go

@@ -57,6 +57,12 @@ func newAssertApprovalCmd(out io.Writer) *cobra.Command {
 			if err != nil {
 				return ErrorBeforePrintingUsage(cmd, err.Error())
 			}
+
+			err = MuXRequiredFlags(cmd, []string{"fingerprint", "artifact-type"}, true)
+			if err != nil {
+				return err
+			}
+
 			return ValidateRegistryFlags(cmd, o.fingerprintOptions)
 
 		},

cmd/kosli/assertApproval_test.go

@@ -93,13 +93,12 @@ func (suite *AssertApprovalCommandTestSuite) TestAssertApprovalCmd() {
 			cmd:       fmt.Sprintf(`assert approval --flow %s %s`, suite.flowName, suite.defaultKosliArguments),
 			golden:    "Error: docker image name or file/dir path is required when --fingerprint is not provided\nUsage: kosli assert approval [IMAGE-NAME | FILE-PATH | DIR-PATH] [flags]\n",
 		},
-		// TODO: this test case does not pass as the validation does not check for it
-		// {
-		// 	wantError: true,
-		// 	name:      "providing both --fingerprint and --artifact-type fails",
-		// 	cmd:       fmt.Sprintf(`assert approval --artifact-type file --fingerprint %s --flow %s %s`, suite.fingerprint, suite.flowName, suite.defaultKosliArguments),
-		// 	golden:    "COMPLIANT\n",
-		// },
+		{
+			wantError: true,
+			name:      "providing both --fingerprint and --artifact-type fails",
+			cmd:       fmt.Sprintf(`assert approval --artifact-type file --fingerprint %s --flow %s %s`, suite.fingerprint, suite.flowName, suite.defaultKosliArguments),
+			golden:    "Error: only one of --fingerprint, --artifact-type is allowed\n",
+		},
 		{
 			wantError: true,
 			name:      "8 missing --flow fails",