From 1d06d3f7584a8447d2b300b84b4b72cc7da00f6a Mon Sep 17 00:00:00 2001 From: Josh McSavaney Date: Mon, 21 Apr 2025 12:23:59 -0400 Subject: [PATCH] Use the correct form of `md5.Sum`. `md5.New().Sum(foo)` appends the MD5 hash for nil to foo. See https://go.dev/play/p/vSW0U3Hq4qk (different algo but same issue). Signed-off-by: Josh McSavaney --- internal/gitutil/gitutil.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/gitutil/gitutil.go b/internal/gitutil/gitutil.go index 42ead2f11..fd1a9ddb9 100644 --- a/internal/gitutil/gitutil.go +++ b/internal/gitutil/gitutil.go @@ -335,7 +335,8 @@ func (gur *GitUpstreamRepo) getRepoDir(uri string) string { var hash = md5.Sum([]byte(uri)) return strings.ToLower(hex.EncodeToString(hash[:])) } - return strings.ToLower(base32.StdEncoding.EncodeToString(md5.New().Sum([]byte(uri)))) + sum := md5.Sum([]byte(uri)) + return strings.ToLower(base32.StdEncoding.EncodeToString(sum[:])) } // getRepoCacheDir