Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade rustls, pem, tame-oauth, and webpki #644

Closed
4 tasks done
clux opened this issue Oct 7, 2021 · 2 comments · Fixed by #704
Closed
4 tasks done

upgrade rustls, pem, tame-oauth, and webpki #644

clux opened this issue Oct 7, 2021 · 2 comments · Fixed by #704
Assignees
@clux @kazk
Labels
blocked awaiting upstream work dependencies upgrades to dependencies

Comments

@clux
Copy link
Member

clux commented Oct 7, 2021 •
edited by kazk
Loading

These have breaking changes that were found during the last version upgrade in #643.

The relevant backouts that we would like to undo are: 87eeb01 and f2890b1 .

Also likely crypto related: we bumped tokio-tungstenite by one minor to 0.15.0, giving us tungstenite-rs@0.14.0 (with some ring bump changes).
@clux clux added the dependencies upgrades to dependencies label Oct 7, 2021
@clux clux changed the title upgrade rustls pem and webpki upgrade rustls, pem, tame-oauth, and webpki Oct 7, 2021
@clux clux moved this to Backlog in Kube Roadmap Oct 26, 2021
@clux clux added the help wanted Not immediately prioritised, please help! label Nov 3, 2021
@clux clux self-assigned this Nov 4, 2021
@clux clux removed the help wanted Not immediately prioritised, please help! label Nov 4, 2021
@clux
Copy link
Member Author

clux commented Nov 4, 2021

Going to take a stab at upgrading rustls.

@clux clux moved this from Backlog to In Progress in Kube Roadmap Nov 4, 2021
clux added a commit that referenced this issue Nov 4, 2021
@clux
attempt upgrading rustls - for #644
87e471f 
a bit of major change based on the massive release history in https://github.com/rustls/rustls#release-history
it has some helpful changes, but it introduces a massive builder on the
ClientConfig which needs to be specified in a particular order.

not sure i got it all correct, or if i have changed behaviour here.

and there is one outstanding issue with converting to a HttpsConnector

Signed-off-by: clux <[email protected]>
@clux clux added the blocked awaiting upstream work label Nov 5, 2021
@clux clux closed this as completed Nov 5, 2021
Repository owner moved this from In Progress to Done in Kube Roadmap Nov 5, 2021
@clux clux reopened this Nov 5, 2021
Repository owner moved this from Done to Backlog in Kube Roadmap Nov 5, 2021
@kazk
Copy link
Member

kazk commented Nov 5, 2021

I'll do tame-oauth. I was going to clean up OAuthError next for #688.

clux added a commit that referenced this issue Nov 7, 2021
@clux
attempt upgrading rustls - for #644
de23e0b 
a bit of major change based on the massive release history in https://github.com/rustls/rustls#release-history
it has some helpful changes, but it introduces a massive builder on the
ClientConfig which needs to be specified in a particular order.

not sure i got it all correct, or if i have changed behaviour here.

and there is one outstanding issue with converting to a HttpsConnector

Signed-off-by: clux <[email protected]>
This was referenced Nov 11, 2021
Merged
Merged
kazk pushed a commit to kazk/kube-rs that referenced this issue Nov 11, 2021
@clux @kazk
attempt upgrading rustls - for kube-rs#644
0b4fe69 
a bit of major change based on the massive release history in https://github.com/rustls/rustls#release-history
it has some helpful changes, but it introduces a massive builder on the
ClientConfig which needs to be specified in a particular order.

not sure i got it all correct, or if i have changed behaviour here.

and there is one outstanding issue with converting to a HttpsConnector

Signed-off-by: clux <[email protected]>
@kazk kazk mentioned this issue Nov 11, 2021
Merged
3 tasks
kazk pushed a commit to kazk/kube-rs that referenced this issue Nov 18, 2021
@clux @kazk
attempt upgrading rustls - for kube-rs#644
81401ce 
a bit of major change based on the massive release history in https://github.com/rustls/rustls#release-history
it has some helpful changes, but it introduces a massive builder on the
ClientConfig which needs to be specified in a particular order.

not sure i got it all correct, or if i have changed behaviour here.

and there is one outstanding issue with converting to a HttpsConnector

Signed-off-by: clux <[email protected]>
@clux clux moved this from Backlog to In Progress in Kube Roadmap Nov 22, 2021
@kazk kazk closed this as completed in #704 Nov 23, 2021
Repository owner moved this from In Progress to Done in Kube Roadmap Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clux clux

@kazk kazk

Labels
blocked awaiting upstream work dependencies upgrades to dependencies
Projects
Kube Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rustls to 0.20.1 kazk/kube-rs
2 participants
@clux @kazk