fix: Minor fix

Signed-off-by: Abhijeet Dhumal <[email protected]>

Author: abhijeet-dhumal

kubeflow/trainer/backends/kubernetes/backend.py

@@ -606,9 +606,7 @@ def _get_trainjob_spec(
             if isinstance(trainer, (types.CustomTrainer, types.CustomTrainerContainer)):
                 if runtime.trainer.trainer_type != types.TrainerType.CUSTOM_TRAINER:
                     raise ValueError(f"CustomTrainer can't be used with {runtime} runtime")
-                trainer_cr = utils.get_trainer_cr_from_custom_trainer(
-                    runtime, trainer, trainer_overrides
-                )
+                trainer_cr = utils.get_trainer_cr_from_custom_trainer(runtime, trainer)
 
             # If users choose to use a builtin trainer for post-training.
             elif isinstance(trainer, types.BuiltinTrainer):

kubeflow/trainer/backends/kubernetes/utils.py

@@ -347,18 +347,15 @@ def get_command_using_train_func(
 def get_trainer_cr_from_custom_trainer(
     runtime: types.Runtime,
     trainer: Union[types.CustomTrainer, types.CustomTrainerContainer],
-    trainer_overrides: Optional[dict[str, Any]] = None,
 ) -> models.TrainerV1alpha1Trainer:
     """
     Get the Trainer CR from the custom trainer.
 
     Args:
         runtime: The runtime configuration.
         trainer: The custom trainer or container configuration.
-        trainer_overrides: Optional overrides for image, command, or args from options.
     """
     trainer_cr = models.TrainerV1alpha1Trainer()
-    trainer_overrides = trainer_overrides or {}
 
     # Add number of nodes to the Trainer.
     if trainer.num_nodes:
@@ -370,14 +367,13 @@ def get_trainer_cr_from_custom_trainer(
 
     if isinstance(trainer, types.CustomTrainer):
         # If CustomTrainer is used, generate command from function.
-        if trainer.func is not None:
-            trainer_cr.command = get_command_using_train_func(
-                runtime,
-                trainer.func,
-                trainer.func_args,
-                trainer.pip_index_urls,
-                trainer.packages_to_install,
-            )
+        trainer_cr.command = get_command_using_train_func(
+            runtime,
+            trainer.func,
+            trainer.func_args,
+            trainer.pip_index_urls,
+            trainer.packages_to_install,
+        )
     else:
         # Alternatively, set the Trainer image.
         trainer_cr.image = trainer.image