Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for kfctl_istio_dex.yaml in website #1592

Closed
krishnadurai opened this issue Feb 3, 2020 · 6 comments
Closed

Update documentation for kfctl_istio_dex.yaml in website #1592

krishnadurai opened this issue Feb 3, 2020 · 6 comments
Assignees
Labels

Comments

@krishnadurai
Copy link
Contributor

Documentation for yaml config kfctl_istio_dex in the website needs to be updated in order to:

  1. Accommodate comments removed from the KfDef config files. (add v1.0.0 kfdef for all platforms with new kusotmize tool manifests#826)
  2. Convert naming to kfctl_istio_dex (Refactor existing_arrikto into a community supported config manifests#599)

/assign @krishnadurai
/cc @yanniszark @johnugeorge
/area docs
/priority p1

Relates to #1582

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.55

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor

jlewi commented Feb 18, 2020

@yanniszark @krishnadurai is anyone working on this?

@yanniszark
Copy link
Contributor

I believe @krishnadurai said he was working on it a couple of days ago.
@krishnadurai does that still hold?
I can take it up if you're too overloaded.

@krishnadurai
Copy link
Contributor Author

@jlewi @yanniszark I apologise for delaying this. I've made a PR #1707 to address this issue. PTAL.

@sarahmaddox
Copy link
Contributor

This is done.
/close

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox: Closing this issue.

In response to this:

This is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants