Fix p4d.24xlarge reporting wrong volume limit #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Code Coverage Diff
|
torredil
reviewed
Feb 20, 2025
ElijahQuinones
force-pushed
the
p4d.24xlarge
branch
from
e6ec0c5 to
b599f5f
Compare
k8s-ci-robot
added
size/S
ElijahQuinones
force-pushed
the
p4d.24xlarge
branch
4 times, most recently
from
d56113a to
0dea4dc
Compare
AndrewSirenko
approved these changes
Feb 27, 2025
k8s-ci-robot
added
the
lgtm
ConnorJC3
approved these changes
Feb 27, 2025
ElijahQuinones
force-pushed
the
p4d.24xlarge
branch
from
0dea4dc to
20599fc
Compare
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
ElijahQuinones
force-pushed
the
p4d.24xlarge
branch
from
20599fc to
87f6f7b
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What is this PR about? / Why do we need it?
fixes #2301
How was this change tested?
Eddie manually attached 28 volumes to a p4d.24xlarge and the public docs have been updated to show it can have 28 ebs volumes attached see https://docs.aws.amazon.com/ec2/latest/instancetypes/ac.html#ac_storage-ebs
Does this PR introduce a user-facing change?