remove default option, always create DesitnaitonRule with istio provider

Signed-off-by: greg pereira <[email protected]>

Author: Gregory-Pereira

config/charts/inferencepool/README.md

@@ -211,7 +211,6 @@ These are the options available to you with `provider.name` set to `istio`:
 
 | **Parameter Name**                          | **Description**                                                                                                        |
 |---------------------------------------------|------------------------------------------------------------------------------------------------------------------------|
-| `istio.destinationRule.enabled`            | Enable creation of an Istio DestinationRule to configure traffic routing. |
 | `istio.destinationRule.host`            | Custom host value for the destination rule. If not set this will use the default value which is derrived from the epp service name and release namespace to gerenate a valid service address. |
 | `istio.destinationRule.trafficPolicy.connectionPool`            | Configure the connectionPool level settings of the traffic policy |
 

config/charts/inferencepool/templates/istio.yaml

@@ -1,6 +1,4 @@
 {{- if eq .Values.provider.name "istio" }}
-{{- if .Values.istio.destinationRule.enabled }}
----
 apiVersion: networking.istio.io/v1beta1
 kind: DestinationRule
 metadata:
@@ -16,4 +14,3 @@ spec:
       {{- .Values.istio.destinationRule.trafficPolicy.connectionPool | toYaml | nindent 6 }}
     {{- end }}
 {{- end }}
-{{- end }}

config/charts/inferencepool/values.yaml

@@ -79,7 +79,6 @@ provider:
 
 istio:
   destinationRule:
-    enabled: true
     # Provide a way to override the default calculated host
     host: "" 
     # Optional: Enables customization of the traffic policy