Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report unit tests as failed overall when any test fails #472

Open
BenTheElder opened this issue Jan 6, 2025 · 1 comment · May be fixed by #480
Open

report unit tests as failed overall when any test fails #472

BenTheElder opened this issue Jan 6, 2025 · 1 comment · May be fixed by #480

Comments

@BenTheElder
Copy link
Member

This should not be "passing" given it has 68 failing test cases:

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-unit-windows-master/1876270253122523136

The exit status of the unit tests should be preserved and reflected as the overall job pass/fail.

The script in scripts/ci-k8s-unit-test.sh doesn't seem to handle this?

Also, this is taking way longer than unit tests on linux, I think we're not giving the tests enough resources to finish reasonably quickly, that seems like something we could easily throw a few more cores at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant