Skip to content

Cluster Autoscaler: OCI SDK is blocking upgrade to go1.24 #8110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atwamahmoud opened this issue May 8, 2025 · 6 comments · Fixed by #8117
Closed

Cluster Autoscaler: OCI SDK is blocking upgrade to go1.24 #8110

atwamahmoud opened this issue May 8, 2025 · 6 comments · Fixed by #8117

Comments

@atwamahmoud
Copy link
Contributor

The current OCI SDK includes generated code which doesn't follow the new go rule for non-constant format strings.

See: https://tip.golang.org/doc/go1.24#vet & golang/go#60529

We need to update the sdk files to unblock the upgrade but since it's generated code we're unable to.
The files with issues can checked here: https://github.com/kubernetes/autoscaler/actions/runs/13842274906/job/38732401709#step:8:292

@atwamahmoud
Copy link
Contributor Author

cc @jlamillan PTAL
cc @x13n

@jlamillan
Copy link
Contributor

Ack

@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@jlamillan
Copy link
Contributor

@atwamahmoud OCI SDK files updated in PR #8117

@atwamahmoud
Copy link
Contributor Author

atwamahmoud commented May 12, 2025

Hey @jlamillan thanks for that
Unfortunately the PR didn't fully fix the issue since some calls persist, e.g. create_instance_console_connection_request_response.go#L72

I created #8121 in the mean time until we fix this along with other dependencies

@jlamillan
Copy link
Contributor

I've submitted a PR to update the OCI SDK and will update if/when it is merged. FYI @atwamahmoud

oracle/oci-go-sdk#575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@adrianmoisey @jlamillan @atwamahmoud @k8s-ci-robot and others