-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Open
Labels
area/cluster-autoscalerarea/helm-chartskind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Copied from aws/eks-charts#1070
Which component are you using?:
- cluster-autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
The helm charts are published using the classic approach with a static webserver and an index.yaml
Describe the solution you'd like:
However in helm 3.8+ the OCI method went GA:
https://blog.bitnami.com/2023/04/httpsblog.bitnami.com202304bitnami-helm-charts-now-oci.html?m=1
https://helm.sh/docs/topics/registries/
https://github.com/helm/helm/releases/tag/v3.8.0
I see two options to use as an OCI mirror:
If you would fully rely on native Github actions to produce these artifacts, the change would be super simple
- name: Run chart-releaser
uses: helm/[email protected]
env:
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
CR_GENERATE_RELEASE_NOTES: true
# ================
# below this line is relevant for OCI publishing
# ================
- name: Login to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Push charts to GHCR
run: |
shopt -s nullglob
for pkg in .cr-release-packages/*; do
if [ -z "${pkg:-}" ]; then
break
fi
helm push "${pkg}" "oci://ghcr.io/${GITHUB_REPOSITORY_OWNER}/charts"
done
Source: https://github.com/prometheus-community/helm-charts/blob/4bbd07f308884d44d0edff23ee60da967dc2cd23/.github/workflows/release.yaml#L39C1-L61C15
Also a lot of other CNCF projects are using this approach.
kg-ops and jb-abbadie
Metadata
Metadata
Assignees
Labels
area/cluster-autoscalerarea/helm-chartskind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.