Skip to content

Conversation

@omerap12
Copy link
Member

@omerap12 omerap12 commented Oct 7, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

When running ./hack/update-gofmt.sh and then git status there are a lot of files to be changed due to aws-sdk.
Example:

modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/awserr/error.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/client/default_retryer.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/corehandlers/awsinternal.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/credentials/chain_provider.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/credentials/credentials.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/credentials/ec2rolecreds/ec2_role_provider.go
modified:   cluster-autoscaler/cloudprovider/aws/aws-sdk-go/aws/credentials/endpointcreds/provider.go
...

This PR silence them.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Signed-off-by: Omer Aplatony <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2025
@jackfrancis
Copy link
Contributor

🙂 I think we should do this instead: #8631

@omerap12
Copy link
Member Author

omerap12 commented Oct 8, 2025

🙂 I think we should do this instead: #8631

Since our test-and-verify ci doesn't complain about it I thought we wanna ignore it.
Cool, thanks!
/close

@k8s-ci-robot
Copy link
Contributor

@omerap12: Closed this PR.

In response to this:

🙂 I think we should do this instead: #8631

Since our test-and-verify ci doesn't complain about it I thought we wanna ignore it.
Cool, thanks!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omerap12 omerap12 mentioned this pull request Oct 23, 2025
@jackfrancis
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

@jackfrancis: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for your patience @omerap12!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@omerap12
Copy link
Member Author

/area cluster-autoscaler

@k8s-ci-robot k8s-ci-robot merged commit 3dd38e6 into kubernetes:master Oct 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants