-
Notifications
You must be signed in to change notification settings - Fork 4.3k
exclude aws-sdk-go from gofmt #8624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
|
🙂 I think we should do this instead: #8631 |
Since our test-and-verify ci doesn't complain about it I thought we wanna ignore it. |
|
@omerap12: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@jackfrancis: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jackfrancis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks for your patience @omerap12!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area cluster-autoscaler |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When running
./hack/update-gofmt.shand thengit statusthere are a lot of files to be changed due to aws-sdk.Example:
This PR silence them.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: