Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KRI in Envoy resource names without breaking metrics #13263

Open
lobkovilya opened this issue Mar 28, 2025 · 0 comments
Open

Use KRI in Envoy resource names without breaking metrics #13263

lobkovilya opened this issue Mar 28, 2025 · 0 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

Description

We can rename resources that have stat_prefix or alt_stat_name without breaking client's dashboards.

It's possible to rename:

  • Sidecar
    • Inbound, Outbound listeners (metrics are emitted as “listener.<address as string>.“)
    • Inbound, Outbound clusters (keeping the old alt_stat_name)
    • Routes (when stat_prefix is empty Envoy doesn't emit route stats, so we can rename them)
  • ZoneIngress
    • Listeners
    • Clusters
  • ZoneEgress
    • Listeners
    • Clusters
    • FilterChains
    • Routes
@lobkovilya lobkovilya added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Mar 28, 2025
@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lobkovilya @lukidzi