Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of deployment invalid #4

Open
robmoorman opened this issue Mar 21, 2017 · 0 comments
Open

Status of deployment invalid #4

robmoorman opened this issue Mar 21, 2017 · 0 comments
Assignees

Comments

@robmoorman
Copy link
Contributor

robmoorman commented Mar 21, 2017

This part:

for deployment in service['deployments']:
    if deployment.get('status') != 'PRIMARY':
        continue

    desired = deployment['desiredCount']
    pending = deployment['pendingCount']
    running = deployment['runningCount']

    return '%s (%s/%s)' % (name, pending + running, desired)
return name

Often a deployment is primary and has a running count of 2 when the desired count is also 2 (more or less also occurs).
In this scenario tasks in other non-primary deployments are draining.

Maybe we should determine when the primary deployment has reached it's desired count (when running counts matches), that the deployment is waiting until other tasks are drained.

With this scenario you probably prevent staring at log outputs were it says 'Web (2/2)' for some time, where people expect the deployment 'should' already be completed (but it's not, since tasks are draining).

Agree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants