driver/rawnetworkinterfacedriver: make start_record() block until capture started

The expectation of RawNetworkInterfaceDriver.start_record() is that it
returns once the packet capturing is running, so later code can start
right away generating packets that are received on the interface.

This does not work reliably currently because the labgrid-raw-interface
helper (wrapping tcpdump) is started via subprocess.Popen(), but that
does not mean the capture is actually running just yet.

To fix this, wait until the subprocess emits "tcpdump: listening on",
which is tcpdump's way of telling that it's now actually capturing.

Signed-off-by: Bastian Krause <[email protected]>

Author: Bastian-Krause

labgrid/driver/rawnetworkinterfacedriver.py

@@ -216,10 +216,30 @@ def start_record(self, filename, *, count=None, timeout=None):
             cmd.append(str(timeout))
         cmd = self._wrap_command(cmd)
         if filename is None:
-            self._record_handle = subprocess.Popen(cmd, stdout=subprocess.PIPE)
+            self._record_handle = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
         else:
             with open(filename, "wb") as outdata:
                 self._record_handle = subprocess.Popen(cmd, stdout=outdata, stderr=subprocess.PIPE)
+
+        # wait for capture start
+        stderr = b""
+        while True:
+            line = self._record_handle.stderr.readline()
+            if not line:  # process ended prematurely
+                try:
+                    self._stop(self._record_handle)
+                except subprocess.CalledProcessError as e:
+                    # readd consumed stderr to exception
+                    e.stderr = stderr
+                    raise
+
+            if line.startswith(b"tcpdump: listening on"):
+                break
+
+            # collect and log other lines in stderr before capturing has started
+            stderr += line
+            self.logger.warning(line.decode().rstrip())
+
         return self._record_handle
 
     @Driver.check_active