From 33f94810bea0232c9e1f4d254086a66555264f90 Mon Sep 17 00:00:00 2001 From: Amanda Muniz Date: Wed, 7 Apr 2021 23:13:27 -0300 Subject: [PATCH 1/4] [#155] Adding components tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Amanda Muniz Co-authored-by: Letícia Araujo --- app/src/tests/components/Snackbar.test.js | 20 +++++++++++++++++++ app/src/tests/components/StoryList.test.js | 23 ++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 app/src/tests/components/Snackbar.test.js create mode 100644 app/src/tests/components/StoryList.test.js diff --git a/app/src/tests/components/Snackbar.test.js b/app/src/tests/components/Snackbar.test.js new file mode 100644 index 0000000..8a53b72 --- /dev/null +++ b/app/src/tests/components/Snackbar.test.js @@ -0,0 +1,20 @@ +import React from 'react'; +import Snackbar from '../../components/Snackbar'; +import Adapter from 'enzyme-adapter-react-16'; +import renderer from 'react-test-renderer'; +import Enzyme from 'enzyme'; +import { Provider } from 'react-redux' +import { createStore } from "redux"; + +Enzyme.configure({ adapter: new Adapter() }); + +it('renders correctly', () => { + const tree = renderer + .create( jest.fn()} + />) + .toJSON(); + expect(tree).toMatchSnapshot(); +}); \ No newline at end of file diff --git a/app/src/tests/components/StoryList.test.js b/app/src/tests/components/StoryList.test.js new file mode 100644 index 0000000..1b5910a --- /dev/null +++ b/app/src/tests/components/StoryList.test.js @@ -0,0 +1,23 @@ +import React from 'react'; +import StoryList from '../../components/StoryList'; +import Adapter from 'enzyme-adapter-react-16'; +import renderer from 'react-test-renderer'; +import Enzyme from 'enzyme'; +import { Provider } from 'react-redux' +import { createStore } from "redux"; +import storyReducer from '../../ducks/stories' + + +Enzyme.configure({ adapter: new Adapter() }); + +it('renders correctly', () => { + const store = createStore(storyReducer); + const tree = renderer + .create( jest.fn()} + undo_delete = {false} + handleSnackbarClick = {() => jest.fn()} + />) + expect(tree).toMatchSnapshot(); + .toJSON(); +)}); \ No newline at end of file From e3b2c877265ed912dcdb3f7134a9c5923e901b3e Mon Sep 17 00:00:00 2001 From: Amanda Muniz Date: Thu, 8 Apr 2021 12:59:25 -0300 Subject: [PATCH 2/4] [#155] - Adding Snackbar test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Amanda Muniz Co-authored-by: Letícia Araujo --- app/src/tests/components/Snackbar.test.js | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/app/src/tests/components/Snackbar.test.js b/app/src/tests/components/Snackbar.test.js index 8a53b72..9e1b78f 100644 --- a/app/src/tests/components/Snackbar.test.js +++ b/app/src/tests/components/Snackbar.test.js @@ -1,20 +1,13 @@ -import React from 'react'; -import Snackbar from '../../components/Snackbar'; +import MessageSnackbar from '../../components/Snackbar'; import Adapter from 'enzyme-adapter-react-16'; -import renderer from 'react-test-renderer'; import Enzyme from 'enzyme'; -import { Provider } from 'react-redux' -import { createStore } from "redux"; Enzyme.configure({ adapter: new Adapter() }); -it('renders correctly', () => { - const tree = renderer - .create( jest.fn()} - />) - .toJSON(); - expect(tree).toMatchSnapshot(); -}); \ No newline at end of file +describe('Testing SnackBar', () => { + + it('should render as expected', function() { + const tree = MessageSnackbar({notification_text: 'test'}, {handleClose: () => jest.fn()}, {variant: "success" }); + expect(tree).toMatchSnapshot(); + }); + }); \ No newline at end of file From 6bc9de52c35d9e76d9da53da06b85a9d38e2cfb3 Mon Sep 17 00:00:00 2001 From: Leticia Araujo Date: Thu, 8 Apr 2021 13:21:29 -0300 Subject: [PATCH 3/4] [#155] Addition of tests Co-authored-by: Leticia Araujo Co-authored-by: Amanda Muniz --- app/src/tests/components/StoryList.test.js | 23 ------------------- .../tests/components/StorySnackBar.test.js | 13 +++++++++++ 2 files changed, 13 insertions(+), 23 deletions(-) delete mode 100644 app/src/tests/components/StoryList.test.js create mode 100644 app/src/tests/components/StorySnackBar.test.js diff --git a/app/src/tests/components/StoryList.test.js b/app/src/tests/components/StoryList.test.js deleted file mode 100644 index 1b5910a..0000000 --- a/app/src/tests/components/StoryList.test.js +++ /dev/null @@ -1,23 +0,0 @@ -import React from 'react'; -import StoryList from '../../components/StoryList'; -import Adapter from 'enzyme-adapter-react-16'; -import renderer from 'react-test-renderer'; -import Enzyme from 'enzyme'; -import { Provider } from 'react-redux' -import { createStore } from "redux"; -import storyReducer from '../../ducks/stories' - - -Enzyme.configure({ adapter: new Adapter() }); - -it('renders correctly', () => { - const store = createStore(storyReducer); - const tree = renderer - .create( jest.fn()} - undo_delete = {false} - handleSnackbarClick = {() => jest.fn()} - />) - expect(tree).toMatchSnapshot(); - .toJSON(); -)}); \ No newline at end of file diff --git a/app/src/tests/components/StorySnackBar.test.js b/app/src/tests/components/StorySnackBar.test.js new file mode 100644 index 0000000..ed39551 --- /dev/null +++ b/app/src/tests/components/StorySnackBar.test.js @@ -0,0 +1,13 @@ +import MessageSnackbar from '../../components/StorySnackbar'; +import Adapter from 'enzyme-adapter-react-16'; +import Enzyme from 'enzyme'; + +Enzyme.configure({ adapter: new Adapter() }); + +describe('Testing StorySnackBar', () => { + + it('should render as expected', function() { + const tree = MessageSnackbar({notification_text: 'test'}, {handleClose: () => jest.fn()}, {variant: "success" }); + expect(tree).toMatchSnapshot(); + }); + }); \ No newline at end of file From c86bca0adc14ea3dc22ee8eb1c738fec3670264f Mon Sep 17 00:00:00 2001 From: Leticia Araujo Date: Thu, 22 Apr 2021 14:35:56 -0300 Subject: [PATCH 4/4] [#176] - Adding SOLID principles for unit testing --- app/src/tests/ducks/stories.test.js | 8 ++++++-- app/src/tests/ducks/utters.test.js | 2 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/src/tests/ducks/stories.test.js b/app/src/tests/ducks/stories.test.js index 4cc978c..a8a9a24 100644 --- a/app/src/tests/ducks/stories.test.js +++ b/app/src/tests/ducks/stories.test.js @@ -91,17 +91,21 @@ describe('get story method', () => { }) }) -describe('validate content method', () => { +describe('warn about two intents problem', () => { it('should warn about two intents problem', () => { let content = [{ id: 1, type: 'utter' }, { id: 1, type: 'intent' }, { id: 2, type: 'intent' }]; expect(validationContent(content)).toEqual(message.story.two_intents) - }) + }) +}) +describe('warn about starting with intents problem', () => { it('should warn about starting with intents problem', () => { let content = [{ id: 1, type: 'utter' }, { id: 1, type: 'intent' }, { id: 1, type: 'utter' }]; expect(validationContent(content)).toEqual(message.story.first_element) }) +}) +describe('return a empty string when everything is fine', () => { it('should return a empty string when everything is fine', () => { let content = [{ id: 1, type: 'intent' }, { id: 1, type: 'utter' }]; expect(validationContent(content)).toEqual('') diff --git a/app/src/tests/ducks/utters.test.js b/app/src/tests/ducks/utters.test.js index 8306b27..d14a393 100644 --- a/app/src/tests/ducks/utters.test.js +++ b/app/src/tests/ducks/utters.test.js @@ -32,7 +32,9 @@ describe('add utter content method', () => { new_state.old_content = [['', '']] expect(addUtterContent(INITIAL_STATE)).toEqual(new_state); }) +}) +describe('add utter to state in alternatives', () => { it('should add utter to state in alternatives', () => { let state = clone(INITIAL_STATE); state.multiple_alternatives = true