Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wish: legendPar low/high bounds as list #289

Open
ayezioro opened this issue Aug 31, 2016 · 4 comments
Open

Wish: legendPar low/high bounds as list #289

ayezioro opened this issue Aug 31, 2016 · 4 comments

Comments

@ayezioro
Copy link
Contributor

Hi,
As for yesterday's wonderful webinar on Ladybug (thanks Chris), i think it will be useful if the legendPar component will allow the low/high bounds inputs a list of values.
This come handy when you use the conditionalStatement_. If you want to compare alternatives you need the values of the wind roses, sunpaths to be equal (temperature, humidity, etc). Right now it gives you min/max values or all values equal if you give a fixed low/high bounds.
Makes sense?
Thanks,
-A.

@mostaphaRoudsari
Copy link
Member

mostaphaRoudsari commented Sep 11, 2016

@ayezioro I might be wrong but I think the list functionality is already there. Here is an example. Am I missing something?

@ayezioro
Copy link
Contributor Author

Hi Mostapha,
Almost forgot about this and worse ... almost forgot what i ment.
But now i get it. See this image and file:
capture
https://www.dropbox.com/s/vpzggrq0jkfk7pm/1-WindAndNaturalVentilation_AY.gh?dl=

For instance, i want to plot the wind rose with conditional statements. Then i want to define the bounds of the legend for each of the roses plotted (one for each statement). As you see, i can't. The options are that without legendPar each rose will plot according to it's local low/high bounds. Or they will take the highest bound of the legendPar (or the last in the list) for all of them. The first one is not bad at all. But my point is that when you want to compare, for instance, different locations, the scale legend will be different and i want them to be similar for comparison purposes.
Hope the wish is clear now.
Thanks,
-A.
Thanks,
-A.

@chriswmackey
Copy link
Member

@ayezioro ,
Thanks for explaining and
@mostaphaRoudsari ,
Thanks for asking for clarification.

In this case, this seems to be a duplicate of a Honeybee issue here:
ladybug-tools/honeybee-legacy#251
We can leave this issue here as I feel that it is more of a Ladybug issue than a Honeybee issue anyway.

I got 10% of the way into implementing this and I realized that it would really take a while to implement on all components with legendPar. At present, I think that it is only working for the 3D chart and the Sunpath. As such, I was thinking of postponing it until we remade the components for the new Ladybug. @mostaphaRoudsari , do you think that this plan is still a good one? Also, if any developer is feeling ambitious to implement this on other components, please go for it.

-Chris

@mostaphaRoudsari
Copy link
Member

Thank you Abraham for clarification. That is missing for a long time.

@chriswmackey agreed! Let's keep it for the new development as it's quite doable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants