Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2: Implement a better separation between dev and prod functionality for the OnChainProposer. #2188

Open
4 tasks
fkrause98 opened this issue Mar 10, 2025 · 0 comments

Comments

@fkrause98
Copy link
Contributor

Description

Currently, to distinguish when to use (or not) a certain verifier, we simply check with if statements
certain variables, this is dangerously error prone. I think the correct would be to have:

  • 2 contracts.

  • They should have almost the same code, but be different enough to be used in dev and prod.

  • We should also have checks for which contract we're using, something like the keccack
    of each contract to check we're deploying exactly the one we want.

  • Keep a CI check that guarantees the dev and prod contracts stay mostly the same, besides the few needed
    changes for each environment.

@fkrause98 fkrause98 changed the title L2: Better separate dev and prod functionality L2: Implement a better separation between dev and prod functionality Mar 10, 2025
@fkrause98 fkrause98 changed the title L2: Implement a better separation between dev and prod functionality L2: Implement a better separation between dev and prod functionality for the OnChainProposer. Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant