Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2: organize each prover backend's calldata in their own structs in the OnChainProposer contract #2198

Open
xqft opened this issue Mar 11, 2025 · 0 comments
Labels
L2 Rollup client

Comments

@xqft
Copy link
Contributor

xqft commented Mar 11, 2025

Currently we take all fields as separate parameters in the verify() function:

    function verify(
        uint256 blockNumber,
        //risc0
        bytes calldata risc0BlockProof,
        bytes32 risc0ImageId,
        bytes32 risc0JournalDigest,
        //sp1
        bytes32 sp1ProgramVKey,
        bytes calldata sp1PublicValues,
        bytes calldata sp1ProofBytes,
        //pico
        bytes32 picoRiscvVkey,
        bytes calldata picoPublicValues,
        uint256[8] calldata picoProof
    ) external override onlySequencer {

(this is after #1922)
it would be nice if we had something like struct SP1Calldata struct Risc0Calldata etc containing these fields.

@xqft xqft added the L2 Rollup client label Mar 11, 2025
@xqft xqft added this to ethrex_l2 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Rollup client
Projects
Status: No status
Status: No status
Development

No branches or pull requests

1 participant