chore: new Rust lints (0xMiden#1140)

Author: igamigo

crates/rust-client/src/note/note_screener.rs

@@ -98,11 +98,10 @@ where
                     // p2ide
                     let script_root = note.script().root();
 
-                    if script_root == WellKnownNote::P2IDE.script_root() {
-                        if let Some(relevance) = Self::check_p2ide_recall_consumability(note, &id)?
-                        {
-                            note_relevances.push((id, relevance));
-                        }
+                    if script_root == WellKnownNote::P2IDE.script_root()
+                        && let Some(relevance) = Self::check_p2ide_recall_consumability(note, &id)?
+                    {
+                        note_relevances.push((id, relevance));
                     }
                 },
                 // If an error occurs while checking consumability, we count it as not relevant for

crates/rust-client/src/rpc/mod.rs

@@ -124,17 +124,17 @@ pub trait NodeRpcClient: Send + Sync {
     /// the `/GetBlockByNumber` RPC endpoint.
     async fn get_block_by_number(&self, block_num: BlockNumber) -> Result<ProvenBlock, RpcError>;
 
-    /// Fetches note-related data for a list of [NoteId] using the `/GetNotesById` rpc endpoint.
+    /// Fetches note-related data for a list of [`NoteId`] using the `/GetNotesById` rpc endpoint.
     ///
-    /// For any NoteType::Private note, the return data is only the
-    /// [miden_objects::note::NoteMetadata], whereas for NoteType::Onchain notes, the return
-    /// data includes all details.
+    /// For any `[miden_objects::note::NoteType::Private]` note, the return data is only the
+    /// [`miden_objects::note::NoteMetadata`], whereas for [`miden_objects::note::NoteType::Public`]
+    /// notes, the return data includes all details.
     async fn get_notes_by_id(&self, note_ids: &[NoteId]) -> Result<Vec<FetchedNote>, RpcError>;
 
     /// Fetches info from the node necessary to perform a state sync using the
     /// `/SyncState` RPC endpoint.
     ///
-    /// - `block_num` is the last block number known by the client. The returned [StateSyncInfo]
+    /// - `block_num` is the last block number known by the client. The returned [`StateSyncInfo`]
     ///   should contain data starting from the next block, until the first block which contains a
     ///   note of matching the requested tag, or the chain tip if there are no notes.
     /// - `account_ids` is a list of account IDs and determines the accounts the client is
@@ -207,7 +207,8 @@ pub trait NodeRpcClient: Send + Sync {
     /// then `None` is returned.
     /// The `block_num` parameter is the block number to start the search from.
     ///
-    /// The default implementation of this method uses [NodeRpcClient::check_nullifiers_by_prefix].
+    /// The default implementation of this method uses
+    /// [`NodeRpcClient::check_nullifiers_by_prefix`].
     async fn get_nullifier_commit_height(
         &self,
         nullifier: &Nullifier,
@@ -221,11 +222,11 @@ pub trait NodeRpcClient: Send + Sync {
             .map(|update| update.block_num))
     }
 
-    /// Fetches public note-related data for a list of [NoteId] and builds [InputNoteRecord]s with
-    /// it. If a note is not found or it's private, it is ignored and will not be included in the
-    /// returned list.
+    /// Fetches public note-related data for a list of [`NoteId`] and builds [`InputNoteRecord`]s
+    /// with it. If a note is not found or it's private, it is ignored and will not be included
+    /// in the returned list.
     ///
-    /// The default implementation of this method uses [NodeRpcClient::get_notes_by_id].
+    /// The default implementation of this method uses [`NodeRpcClient::get_notes_by_id`].
     async fn get_public_note_records(
         &self,
         note_ids: &[NoteId],
@@ -256,7 +257,7 @@ pub trait NodeRpcClient: Send + Sync {
     /// The `local_accounts` parameter is a list of account headers that the client has
     /// stored locally and that it wants to check for updates. If an account is private or didn't
     /// change, it is ignored and will not be included in the returned list.
-    /// The default implementation of this method uses [NodeRpcClient::get_account_details].
+    /// The default implementation of this method uses [`NodeRpcClient::get_account_details`].
     async fn get_updated_public_accounts(
         &self,
         local_accounts: &[&AccountHeader],
@@ -280,7 +281,8 @@ pub trait NodeRpcClient: Send + Sync {
     /// Given a block number, fetches the block header corresponding to that height from the node
     /// along with the MMR proof.
     ///
-    /// The default implementation of this method uses [NodeRpcClient::get_block_header_by_number].
+    /// The default implementation of this method uses
+    /// [`NodeRpcClient::get_block_header_by_number`].
     async fn get_block_header_with_proof(
         &self,
         block_num: BlockNumber,
@@ -291,10 +293,10 @@ pub trait NodeRpcClient: Send + Sync {
 
     /// Fetches the note with the specified ID.
     ///
-    /// The default implementation of this method uses [NodeRpcClient::get_notes_by_id].
+    /// The default implementation of this method uses [`NodeRpcClient::get_notes_by_id`].
     ///
     /// Errors:
-    /// - [RpcError::NoteNotFound] if the note with the specified ID is not found.
+    /// - [`RpcError::NoteNotFound`] if the note with the specified ID is not found.
     async fn get_note_by_id(&self, note_id: NoteId) -> Result<FetchedNote, RpcError> {
         let notes = self.get_notes_by_id(&[note_id]).await?;
         notes.into_iter().next().ok_or(RpcError::NoteNotFound(note_id))

crates/rust-client/src/rpc/tonic_client/mod.rs

@@ -198,7 +198,7 @@ impl NodeRpcClient for TonicRpcClient {
     }
 
     /// Sends a sync state request to the Miden node, validates and converts the response
-    /// into a [StateSyncInfo] struct.
+    /// into a [`StateSyncInfo`] struct.
     async fn sync_state(
         &self,
         block_num: BlockNumber,
@@ -223,16 +223,16 @@ impl NodeRpcClient for TonicRpcClient {
         response.into_inner().try_into()
     }
 
-    /// Sends a `GetAccountDetailsRequest` to the Miden node, and extracts an [FetchedAccount] from
-    /// the `GetAccountDetailsResponse` response.
+    /// Sends a `GetAccountDetailsRequest` to the Miden node, and extracts an [`FetchedAccount`]
+    /// from the `GetAccountDetailsResponse` response.
     ///
     /// # Errors
     ///
     /// This function will return an error if:
     ///
     /// - There was an error sending the request to the node.
-    /// - The answer had a `None` for one of the expected fields (account, summary,
-    ///   account_commitment, details).
+    /// - The answer had a `None` for one of the expected fields (`account`, `summary`,
+    ///   `account_commitment`, `details`).
     /// - There is an error during [Account] deserialization.
     async fn get_account_details(&self, account_id: AccountId) -> Result<FetchedAccount, RpcError> {
         let request = proto::account::AccountId { id: account_id.to_bytes() };
@@ -359,7 +359,7 @@ impl NodeRpcClient for TonicRpcClient {
         Ok((block_num, account_proofs))
     }
 
-    /// Sends a `SyncNoteRequest` to the Miden node, and extracts a [NoteSyncInfo] from the
+    /// Sends a `SyncNoteRequest` to the Miden node, and extracts a [`NoteSyncInfo`] from the
     /// response.
     async fn sync_notes(
         &self,

crates/rust-client/src/store/mod.rs

@@ -130,7 +130,7 @@ pub trait Store: Send + Sync {
 
     /// Returns the nullifiers of all unspent input notes.
     ///
-    /// The default implementation of this method uses [Store::get_input_notes].
+    /// The default implementation of this method uses [`Store::get_input_notes`].
     async fn get_unspent_input_note_nullifiers(&self) -> Result<Vec<Nullifier>, StoreError> {
         self.get_input_notes(NoteFilter::Unspent)
             .await?
@@ -162,7 +162,7 @@ pub trait Store: Send + Sync {
     /// that represents whether the block contains notes relevant to the client. Returns `None` if
     /// the block is not found.
     ///
-    /// The default implementation of this method uses [Store::get_block_headers].
+    /// The default implementation of this method uses [`Store::get_block_headers`].
     async fn get_block_header_by_num(
         &self,
         block_number: BlockNumber,
@@ -175,7 +175,7 @@ pub trait Store: Send + Sync {
     /// Retrieves a list of [`BlockHeader`] that include relevant notes to the client.
     async fn get_tracked_block_headers(&self) -> Result<Vec<BlockHeader>, StoreError>;
 
-    /// Retrieves all MMR authentication nodes based on [PartialBlockchainFilter].
+    /// Retrieves all MMR authentication nodes based on [`PartialBlockchainFilter`].
     async fn get_partial_blockchain_nodes(
         &self,
         filter: PartialBlockchainFilter,

crates/rust-client/src/store/note_record/output_note_record/mod.rs

@@ -134,12 +134,12 @@ impl OutputNoteRecord {
         nullifier: Nullifier,
         block_height: u32,
     ) -> Result<bool, NoteRecordError> {
-        if let Some(note_nullifier) = self.nullifier() {
-            if note_nullifier != nullifier {
-                return Err(NoteRecordError::StateTransitionError(
-                    "Nullifier does not match the expected value".to_string(),
-                ));
-            }
+        if let Some(note_nullifier) = self.nullifier()
+            && note_nullifier != nullifier
+        {
+            return Err(NoteRecordError::StateTransitionError(
+                "Nullifier does not match the expected value".to_string(),
+            ));
         }
 
         let new_state = self.state.nullifier_received(block_height)?;

crates/rust-client/src/store/web_store/account/mod.rs

@@ -342,10 +342,10 @@ impl WebStore {
         // Mismatched digests may be due to stale network data. If the mismatched digest is
         // tracked in the db and corresponds to the mismatched account, it means we
         // got a past update and shouldn't lock the account.
-        if let Some(account) = self.get_account_header_by_commitment(*mismatched_digest).await? {
-            if account.id() == *account_id {
-                return Ok(());
-            }
+        if let Some(account) = self.get_account_header_by_commitment(*mismatched_digest).await?
+            && account.id() == *account_id
+        {
+            return Ok(());
         }
 
         let account_id_str = account_id.to_string();

crates/rust-client/src/store/web_store/sync/js_bindings.rs

@@ -60,15 +60,15 @@ extern "C" {
 #[derive(Clone)]
 pub struct JsStateSyncUpdate {
     /// The block number for this update, stored as a string since it will be
-    /// persisted in IndexedDB.
+    /// persisted in `IndexedDB`.
     #[wasm_bindgen(js_name = "blockNum")]
     pub block_num: String,
 
     /// The new block headers for this state update, serialized into a flattened byte array.
     #[wasm_bindgen(js_name = "flattenedNewBlockHeaders")]
     pub flattened_new_block_headers: FlattenedU8Vec,
 
-    /// The block numbers corresponding to each header in flattened_new_block_headers.
+    /// The block numbers corresponding to each header in `flattened_new_block_headers`.
     /// This vec should have the same length as the number of headers, with each index
     /// representing the block number for the header at that same index.
     #[wasm_bindgen(js_name = "newBlockNums")]

crates/rust-client/src/tests.rs

@@ -1140,7 +1140,7 @@ async fn p2ide_transfer_consumed_by_target() {
         InputNoteState::Committed { .. }
     ));
 
-    consume_notes(&mut client, from_account_id, &[note.clone()]).await;
+    consume_notes(&mut client, from_account_id, core::slice::from_ref(&note)).await;
     mock_rpc_api.prove_block();
     client.sync_state().await.unwrap();
 

crates/web-client/src/export.rs

@@ -43,9 +43,9 @@ impl WebClient {
         }
     }
 
-    /// Retrieves the entire underlying web store and returns it as a JsValue
+    /// Retrieves the entire underlying web store and returns it as a `JsValue`
     ///
-    /// Meant to be used in conjunction with the force_import_store method
+    /// Meant to be used in conjunction with the `force_import_store` method
     #[wasm_bindgen(js_name = "exportStore")]
     pub async fn export_store(&mut self) -> Result<JsValue, JsValue> {
         let store = self.store.as_ref().ok_or(JsValue::from_str("Store not initialized"))?;