Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing FeatureSet schema #140

Open
SHerresthal opened this issue Jan 23, 2025 · 2 comments
Open

🐛 Add missing FeatureSet schema #140

SHerresthal opened this issue Jan 23, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@SHerresthal
Copy link

Hi,
is it possible to access also the lamindb.FeatureSet via the lamin client? If not, I would vote for this, because we use it a lot :)
Thank you!

@lazappi lazappi added the question Further information is requested label Jan 28, 2025
@lazappi
Copy link
Collaborator

lazappi commented Jan 28, 2025

Hi @SHerresthal

I've just checked and I think you are right. There is a ln.FeatureSet in Python but the equivalent db$FeatureSet seems to be missing from R. I'm not sure why that would be so I'll need to look into it.

Thanks for raising!

@lazappi lazappi changed the title Accessing Feature Sets 🐛 Add missing FeatureSet schema Jan 28, 2025
@lazappi lazappi added bug Something isn't working and removed question Further information is requested labels Jan 28, 2025
@falexwolf
Copy link
Member

I've just checked and I think you are right. There is a ln.FeatureSet in Python but the equivalent db$FeatureSet seems to be missing from R. I'm not sure why that would be so I'll need to look into it.

In laminr it's called db$Schema, which is the new name for FeatureSet (to be officially launched in the upcoming days with a much better curation flow). lamindb is fully backward compatible so that both names work. The laminhub UI shows "FeatureSet" and "Schema" side-by-side.

For laminr, given there is no existing code written with it, I think one should not invest in building backward compat for the FeatureSet name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants