fallback slug separator to '-' in case of alphanumeric separator

laravel · Feb 3, 2025 · 1406f11 · 1406f11
1 parent 53091c2
commit 1406f11
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/Illuminate/Support/Str.php b/src/Illuminate/Support/Str.php
@@ -1464,6 +1464,7 @@ public static function singular($value)
     public static function slug($title, $separator = '-', $language = 'en', $dictionary = ['@' => 'at'])
     {
         $title = $language ? static::ascii($title, $language) : $title;
+        $separator = ctype_alnum($separator) ? '-' : $separator;
 
         // Convert all dashes/underscores into separator
         $flip = $separator === '-' ? '_' : '-';

diff --git a/tests/Support/SupportStringableTest.php b/tests/Support/SupportStringableTest.php
@@ -739,6 +739,10 @@ public function testSlug()
         $this->assertSame('sometext', (string) $this->stringable('some text')->slug(''));
         $this->assertSame('', (string) $this->stringable('')->slug(''));
         $this->assertSame('', (string) $this->stringable('')->slug());
+        $this->assertSame('hello-world', (string) $this->stringable('hello world')->slug('eb'));
+        $this->assertSame('hello-world', (string) $this->stringable('hello world')->slug('e'));
+        $this->assertSame('hello-world', (string) $this->stringable('hello world')->slug('2'));
+        $this->assertSame('hello-world', (string) $this->stringable('hello world')->slug('2'));
     }
 
     public function testSquish()