First batch of UI changes needed in issues dashboard and annotations UI

based on product feedback

Author: andresgutgon

apps/web/src/actions/evaluationsV2/annotate.ts

@@ -28,6 +28,7 @@ export const annotateEvaluationV2Action = withEvaluation
       providerLog: providerLog,
       commit: ctx.commit,
       workspace: ctx.workspace,
+      currentUser: ctx.user,
     }).then((r) => r.unwrap())
 
     return result

apps/web/src/app/(private)/projects/[projectId]/versions/[commitUuid]/issues/_components/LastSeenCell/index.tsx

@@ -9,6 +9,7 @@ import {
   differenceInMonths,
   differenceInYears,
   format,
+  isSameDay,
 } from 'date-fns'
 import { Tooltip } from '@latitude-data/web-ui/atoms/Tooltip'
 
@@ -34,8 +35,19 @@ function getRelativeTimeText(createdAt: Date, lastSeenDate: Date | null) {
   const now = new Date()
 
   const ageText = formatTimeDistance(createdAt, now)
-  const lastSeenText = formatTimeDistance(dateToUse, now)
 
+  // If last seen is today, show "today" instead of hours
+  let lastSeenText: string
+  if (dateToUse && isSameDay(dateToUse, now)) {
+    lastSeenText = 'today'
+  } else {
+    lastSeenText = formatTimeDistance(dateToUse, now)
+  }
+
+  // Format: "today / X old" or "X ago / Y old"
+  if (lastSeenText === 'today') {
+    return `today / ${ageText} old`
+  }
   return `${lastSeenText} ago / ${ageText} old`
 }
 

apps/web/src/app/(private)/projects/[projectId]/versions/[commitUuid]/runs/_components/RunsList/Item.tsx

@@ -1,15 +1,21 @@
 'use client'
 
+import { memo, useMemo } from 'react'
 import { formatDuration } from '$/app/_lib/formatUtils'
 import { relativeTime } from '$/lib/relativeTime'
 import { useActiveRuns } from '$/stores/runs/activeRuns'
-import { Run } from '@latitude-data/constants'
+import {
+  EvaluationConfiguration,
+  EvaluationType,
+  HumanEvaluationMetric,
+  Run,
+} from '@latitude-data/constants'
 import { Button } from '@latitude-data/web-ui/atoms/Button'
-import { Icon } from '@latitude-data/web-ui/atoms/Icons'
+import { Icon, IconProps } from '@latitude-data/web-ui/atoms/Icons'
 import { Text } from '@latitude-data/web-ui/atoms/Text'
 import { Tooltip } from '@latitude-data/web-ui/atoms/Tooltip'
 import { cn } from '@latitude-data/web-ui/utils'
-import { memo } from 'react'
+import { getEvaluationMetricSpecification } from '$/components/evaluations'
 
 export const RunsListItem = memo(
   ({
@@ -27,6 +33,56 @@ export const RunsListItem = memo(
     stopRun?: ReturnType<typeof useActiveRuns>['stopRun']
     isStoppingRun?: boolean
   }) => {
+    const iconProps = useMemo<IconProps>(() => {
+      if (run.log?.error.code) {
+        return { name: 'circleX', color: 'destructive' }
+      }
+
+      const started = !!run.startedAt
+      const ended = !!run.endedAt
+
+      if (!started && !ended) {
+        return {
+          name: 'circleDashed',
+          color: 'foregroundMuted',
+          className: 'stroke-[2.25]',
+        }
+      }
+
+      if (started && !ended) {
+        return { name: 'loader', color: 'foregroundMuted', spin: true }
+      }
+
+      const annotations = run.annotations ?? []
+
+      if (annotations.length === 0) {
+        return { name: 'circleDashed', color: 'foregroundMuted' }
+      }
+
+      const uiAnnotations = annotations.filter((annotation) => {
+        const evaluation = annotation.evaluation
+        const supportManual =
+          getEvaluationMetricSpecification(evaluation).supportsManualEvaluation
+
+        if (!supportManual) return false
+
+        const config = evaluation.configuration as EvaluationConfiguration<
+          EvaluationType.Human,
+          HumanEvaluationMetric
+        >
+        return config.enableControls === true
+      })
+
+      const uiAnnotation = uiAnnotations[0]
+
+      if (!uiAnnotation) return { name: 'circleDashed', color: 'success' }
+
+      const result = uiAnnotation.result
+      return {
+        name: result.hasPassed ? 'thumbsUp' : 'thumbsDown',
+        color: result.hasPassed ? 'success' : 'destructive',
+      }
+    }, [run])
     return (
       <Tooltip
         asChild
@@ -48,34 +104,13 @@ export const RunsListItem = memo(
             }}
           >
             <div className='min-w-0 min-h-8 flex items-center justify-start gap-2.5 truncate'>
-              {run.endedAt ? (
-                <Icon
-                  name={
-                    run.log?.error.code
-                      ? 'circleX'
-                      : run.annotations?.length
-                        ? 'filledBadgeCheck'
-                        : 'circleCheck'
-                  }
-                  size='normal'
-                  color={run.log?.error.code ? 'destructive' : 'success'}
-                  className='flex-shrink-0'
-                />
-              ) : run.startedAt ? (
-                <Icon
-                  name='loader'
-                  size='normal'
-                  color='foregroundMuted'
-                  className='flex-shrink-0 animate-spin'
-                />
-              ) : (
-                <Icon
-                  name='circleDashed'
-                  size='normal'
-                  color='foregroundMuted'
-                  className='flex-shrink-0 stroke-[2.25]'
-                />
-              )}
+              <Icon
+                size='normal'
+                name={iconProps.name}
+                color={iconProps.color}
+                spin={iconProps.spin}
+                className={cn('flex-shrink-0', iconProps.className)}
+              />
               <Text.H5
                 color={run.log?.error.code ? 'destructive' : 'foreground'}
                 animate={!run.endedAt}

apps/web/src/app/(private)/projects/[projectId]/versions/[commitUuid]/runs/_components/RunsList/index.tsx

@@ -1,5 +1,3 @@
-'use client'
-
 import { RealtimeToggle } from '$/components/RealtimeToggle'
 import { LogicTablePaginationFooter } from '$/components/TablePaginationFooter/LogicTablePaginationFooter'
 import { useActiveRuns } from '$/stores/runs/activeRuns'

packages/core/src/events/events.d.ts

@@ -451,10 +451,12 @@ export type EvaluationV2AnnotatedEvent = LatitudeEventGeneric<
   'evaluationV2Annotated',
   {
     workspaceId: number
+    isNew: boolean
     evaluation: EvaluationV2
     result: EvaluationResultV2
     commit: Commit
     providerLog: ProviderLogDto
+    userEmail?: string | null
   }
 >
 

packages/core/src/lib/analytics/AnalyticsClient.ts

@@ -75,7 +75,9 @@ export class AnalyticsClient {
     // TODO: remove, it's very expensive to have a read operation on each analytics event
     const repo = new WorkspacesRepository(user.id)
     const result = await repo.find(this.workspaceId)
+
     if (result.error) return undefined
+
     const workspace = result.value
 
     // Filtering out some expensive workspaces that are skewing our analytics...

packages/core/src/services/documents/tools/resolve/clientTools.test.ts

@@ -359,4 +359,3 @@ describe('resolveClientToolDefinition', () => {
     })
   })
 })
-

packages/core/src/services/evaluationsV2/annotate.ts

@@ -20,6 +20,7 @@ import {
 } from '../../repositories'
 import { type Commit } from '../../schema/models/types/Commit'
 import { type Workspace } from '../../schema/models/types/Workspace'
+import { type User } from '../../schema/models/types/User'
 import { ProviderLogDto } from '../../schema/types'
 import { extractActualOutput } from './outputs/extract'
 import { createEvaluationResultV2 } from './results/create'
@@ -37,9 +38,11 @@ export async function annotateEvaluationV2<
     evaluation,
     resultScore,
     resultMetadata,
+    currentUser,
   }: {
     workspace: Workspace
     commit: Commit
+    currentUser?: User
     providerLog: ProviderLogDto
     evaluation: EvaluationV2<T, M>
     resultScore: number
@@ -161,11 +164,14 @@ export async function annotateEvaluationV2<
 
   // TODO: We are stepping out of the db instance. This service should accept an instance of Transaction instead.
   const transaction = new Transaction()
+  let alreadyExisted = false
   return await transaction.call(
     async () => {
       let result
 
-      if (existingResult.ok) {
+      alreadyExisted = !!existingResult.ok
+
+      if (alreadyExisted) {
         const { result: updatedResult } = await updateEvaluationResultV2(
           {
             workspace,
@@ -197,6 +203,8 @@ export async function annotateEvaluationV2<
       publisher.publishLater({
         type: 'evaluationV2Annotated',
         data: {
+          isNew: !alreadyExisted,
+          userEmail: currentUser?.email || null,
           workspaceId: workspace.id,
           evaluation: evaluation,
           result: result,